Skip to content

test: issue 1868 (named selection beams testing) #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

jacobrkerstetter
Copy link
Contributor

Description

  • re-enabled portion of named_selection test testing for beam contents after server-side fix

Issue linked

#1868

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter added the testing Anything related to tests label Mar 26, 2025
@jacobrkerstetter jacobrkerstetter self-assigned this Mar 26, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner March 26, 2025 15:56
@github-actions github-actions bot removed the testing Anything related to tests label Mar 26, 2025
@RobPasMue
Copy link
Member

Awesome, thanks for the PR @jacobrkerstetter!

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (267e363) to head (c9647ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1871   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          92       92           
  Lines        8852     8852           
=======================================
  Hits         7983     7983           
  Misses        869      869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) March 28, 2025 12:54
@jacobrkerstetter jacobrkerstetter merged commit e6d8210 into main Mar 31, 2025
48 checks passed
@jacobrkerstetter jacobrkerstetter deleted the test/ns_beam_testing branch March 31, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named selection creation using beams is not capable of retrieving them later
3 participants