-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Logo detection #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Logo detection #1873
Conversation
@RobPasMue My previous branch for logo detection had too many conflicts and I was getting a hard time with it so I created a new one and a new pull request. There is a small fix pending on the API server then it will be ready for full review |
|
fix string
@RobPasMue I added some check for disabling on Linux but I am not sure if it is the correct way to do it. Should I log an issue for it? Also there is one change in the API server that has to be merged otherwise one of the asserts will fail. |
Hi @smereu -- I can't see any "skip on Linux" condition on your PR, sadly. That's what's causing the CI/CD to fail I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few changes -- nonetheless, the PR is looking good, thanks @smereu!
…sys-geometry into feat/logo_detection_1
remove space Co-authored-by: Roberto Pastor Muela <[email protected]>
compact syntax Co-authored-by: Roberto Pastor Muela <[email protected]>
…sys-geometry into feat/logo_detection_1
clean-up and add check_input_types
…sys-geometry into feat/logo_detection_1
@RobPasMue I hope I addressed the comments. I will add the quantity input to this method together with all the other ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smereu - changes look good. Thanks for addressing them. I think there are only 2 comments missing to be resolved:
1- I'd rather access by name (inside the test) whenever we want to validate number of faces of a given body. I'd search for the component with the desired name - and for the specific body we want (also by name), and then validate its face number.
2- I don't think we need the modeler inside prepare tools based on the operations you are performing (just retrieving the backend type). That information is available inside the client already so there is no need for the modeler =)
Removed unnecessary use of modeler and use name instead of index for unit test
…sys-geometry into feat/logo_detection_1
make test pass. To be updated with new build
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
- Coverage 90.18% 90.18% -0.01%
==========================================
Files 92 92
Lines 8852 8902 +50
==========================================
+ Hits 7983 8028 +45
- Misses 869 874 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good @smereu - thanks for handling all my comments!
Description
Exposes logo detection and removal. Logos is exposed as a problem area defined by a list of faces. There is no ability to distinguish multiple logos if present so we expose a single problem area. The problem area has a fix method to remove the logo. There is a find and remove method that allows to remove everything automatically.
Issue linked
Checklist
feat: extrude circle to cylinder
)