Skip to content

feat: repair tools refactoring #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 76 commits into from
May 7, 2025
Merged

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Apr 14, 2025

Description

Refactoring repair tools to move repair stubs to the central area. See the issue for more details.

Issue linked

#1817

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@umutsoysalansys umutsoysalansys changed the title repair tools refactoring feat: repair tools refactoring Apr 14, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 14, 2025
@umutsoysalansys umutsoysalansys self-assigned this Apr 14, 2025
RobPasMue
RobPasMue previously approved these changes May 6, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @umutsoysalansys - just left a few comments. The main one is related to the "DoubleValue". The rest are mostly formatting and docstring suggestions which you can just add and commit =) thanks a lot!! Once comments are resolved, I will approve again and merge.

@umutsoysalansys
Copy link
Contributor Author

umutsoysalansys commented May 7, 2025

@RobPasMue what is the doc error, can we make these things more descriptive? Which py file lines are corresponding to the rst file lines? I can't see

@RobPasMue
Copy link
Member

@RobPasMue what is the doc error, can we make these things more descriptive? Which py file lines are corresponding to the rst file lines? I can't see

I wish we could -- that's just Sphinx and other tools complaining... Nonetheless, the problem is still the docstring I referred to in this comment #1912 (comment)

I would remove the docstring if possible -- the other option is to format it properly based on the comments you are getting, but I know it is a painful process because you have a non-standard docstring

@umutsoysalansys umutsoysalansys requested a review from RobPasMue May 7, 2025 12:50
Co-authored-by: Roberto Pastor Muela <[email protected]>
RobPasMue
RobPasMue previously approved these changes May 7, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) May 7, 2025 13:14
@RobPasMue RobPasMue merged commit ee02433 into main May 7, 2025
45 checks passed
@RobPasMue RobPasMue deleted the feat/grpc-common-layer-refactoring branch May 7, 2025 14:18
@RobPasMue RobPasMue linked an issue May 7, 2025 that may be closed by this pull request
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle gRPC API calls from central location
3 participants