feat: grpc prepare tools stub implementation #1914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed grpc calls from measurement tools
…m/ansys/pyansys-geometry into feat/measurement_tools_relocation
… common stub class now
…m/ansys/pyansys-geometry into feat/measurement_tools_relocation
…m/ansys/pyansys-geometry into feat/prepare_tools_migration # Conflicts: # src/ansys/geometry/core/_grpc/_services/_service.py
16 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1914 +/- ##
========================================
Coverage 90.38% 90.39%
========================================
Files 111 114 +3
Lines 9434 9545 +111
========================================
+ Hits 8527 8628 +101
- Misses 907 917 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
requested changes
Apr 16, 2025
There was a problem hiding this comment.
Pretty decent @jacobrkerstetter! Very minor suggestions -- request review again once it's all handled =)
fixing PR comments
…ys/pyansys-geometry into feat/prepare_tools_migration
RobPasMue
reviewed
Apr 16, 2025
RobPasMue
previously approved these changes
Apr 16, 2025
added 2 commits
April 16, 2025 10:04
…ys/pyansys-geometry into feat/prepare_tools_migration
RobPasMue
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moved prepare tools stub to common location
Issue linked
#1817
Checklist
feat: extrude circle to cylinder)