Skip to content

feat: grpc reachitecture - several modules #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
May 22, 2025
Merged

Conversation

RobPasMue
Copy link
Member

Attempting the rearchitect of several stubs

@RobPasMue RobPasMue self-assigned this May 15, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 92.52874% with 26 lines in your changes missing coverage. Please review.

Project coverage is 90.46%. Comparing base (5200e80) to head (c740715).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v0/conversions.py 86.36% 9 Missing ⚠️
src/ansys/geometry/core/designer/design.py 81.08% 7 Missing ⚠️
...rc/ansys/geometry/core/_grpc/_services/_service.py 94.44% 5 Missing ⚠️
src/ansys/geometry/core/designer/face.py 90.00% 3 Missing ⚠️
src/ansys/geometry/core/designer/body.py 92.85% 1 Missing ⚠️
src/ansys/geometry/core/modeler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1988      +/-   ##
==========================================
+ Coverage   90.35%   90.46%   +0.10%     
==========================================
  Files         123      136      +13     
  Lines        9833     9717     -116     
==========================================
- Hits         8885     8790      -95     
+ Misses        948      927      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue marked this pull request as ready for review May 21, 2025 17:04
@RobPasMue RobPasMue requested a review from a team as a code owner May 21, 2025 17:04
@RobPasMue
Copy link
Member Author

Took longer than anticipated.. and still requires some final verifications. But most of the work is done. I'll continue shortly

@RobPasMue RobPasMue merged commit e0c0848 into main May 22, 2025
44 of 45 checks passed
@RobPasMue RobPasMue deleted the feat/grpc-rearchitect branch May 22, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants