Skip to content

Add CyclicSupport.cs, CyclicSupport.high_low_map & CyclicSupport.low_high_map #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 9, 2024

Conversation

oparreno
Copy link
Contributor

@oparreno oparreno commented Nov 7, 2024

Following the tests made during the pyDPF training, this PR aims to enable using the methods cs, high_low_map & low_high_map in pyDPF.

image

image

@oparreno oparreno requested a review from PProfizi November 7, 2024 15:20
@oparreno oparreno self-assigned this Nov 7, 2024
@oparreno oparreno requested a review from a team as a code owner November 7, 2024 15:20
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (3849393) to head (9f218ed).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1875      +/-   ##
==========================================
- Coverage   88.10%   88.09%   -0.01%     
==========================================
  Files          83       83              
  Lines        9951     9961      +10     
==========================================
+ Hits         8767     8775       +8     
- Misses       1184     1186       +2     

@PProfizi PProfizi changed the title Enable methods cs, high_low_map & low_high_map in pyDPF Add CyclicSupport.cs, CyclicSupport.high_low_map & CyclicSupport.low_high_map Nov 8, 2024
@PProfizi PProfizi added the enhancement New feature or request label Nov 8, 2024
@PProfizi PProfizi modified the milestone: v0.13.2 Nov 8, 2024
@PProfizi PProfizi added this to the 0.13.3 milestone Nov 8, 2024
@oparreno oparreno merged commit f00e62a into master Nov 9, 2024
43 checks passed
@oparreno oparreno deleted the oparreno/cyclic_apis branch November 9, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants