Skip to content

DpfVector BUG: DpfVector were created on one clayer and deleted in another #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

cbellot000
Copy link
Contributor

When working on distributed workflows (in process and gRPC), DPFVector were sometimes created on one clayer and deleted on another. This prevented any changes in the DPFVector.

@cbellot000 cbellot000 requested a review from a team as a code owner March 10, 2025 07:41
@rafacanton rafacanton added the bug Something isn't working label Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (b499d14) to head (b1be3eb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2141      +/-   ##
==========================================
+ Coverage   86.57%   86.66%   +0.08%     
==========================================
  Files          90       90              
  Lines       10310    10303       -7     
==========================================
+ Hits         8926     8929       +3     
+ Misses       1384     1374      -10     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PProfizi
Copy link
Contributor

@cbellot000 could we maybe have a test to ensure behavior is fixed?

@cbellot000
Copy link
Contributor Author

@cbellot000 could we maybe have a test to ensure behavior is fixed?

We do have a test: it's the reason why #2135 is failing :)

@cbellot000 cbellot000 requested a review from PProfizi March 10, 2025 13:19
@cbellot000 cbellot000 merged commit f7be394 into master Mar 10, 2025
46 checks passed
@cbellot000 cbellot000 deleted the bug/dpf_vector branch March 10, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants