Skip to content

updated the documentation, waiting for the pymadpl issue to be resolved. #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

updated the documentation, waiting for the pymadpl issue to be resolved. #226

wants to merge 10 commits into from

Conversation

mcMunich
Copy link

No description provided.

akaszynski
akaszynski reviewed Apr 26, 2022
View reviewed changes
examples/00-basic/00-cycles-to-failure.py
Comment on lines +91 to +94
myResult = np.ones((len(myNodes), 3))
myResult[:, 0] = myNodes
myResult[:, 1] = vm_stress
myResult[:, 2] = np.interp(myResult[:, 1], xPoints, yValues)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow PEP8 when naming variables. Should be using pascal case here.

akaszynski
akaszynski reviewed Apr 26, 2022
View reviewed changes
examples/00-basic/00-cycles-to-failure.py
from ansys.mapdl.core import launch_mapdl
from ansys.dpf import core as dpf
import numpy as np
myDir = r'c:\temp'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best not to specify a directory. By default, PyMAPDL creates a temporary directory that's OS independent. It can be accessed simply by:

mapdl.directory

PProfizi added a commit that referenced this pull request May 31, 2022
@PProfizi
Updated according to comments in PR #226
df5a331
@PProfizi PProfizi mentioned this pull request Oct 27, 2022
Merged
@PProfizi
Copy link
Contributor

PProfizi commented Oct 27, 2022 •
edited
Loading

Hi @mcMunich, I finally got back to this example. Sorry it took so long.
The conclusion is we do not run MAPDL in the PyDPF pipelines, so I had to add the result files to the example files.
I started a new PR due to many changes in master.
You can check #224 and let me know what you think.
If you want to be marked as author of the PR merging the example, you can take the code in #224 and update this current PR. As long as it is close to and the checks pass for #224, I can merge your PR without checks.

@PProfizi
Copy link
Contributor

PProfizi commented Dec 1, 2022

Closed by #591

@PProfizi PProfizi closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcMunich @PProfizi @akaszynski