Skip to content

fix: contact force legend #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshuafairch
Copy link

Flipped master/slave in contact plot legend

Flipped master/slave in contact plot legend
@joshuafairch
Copy link
Author

joshuafairch commented May 12, 2025

Verified plt.plot(t_vals, FX.get_field({"interface": 19, "idtype": 0}).data, label="FX, slave") plots positive contact force. This is originally noted as the slave side.
Verified LSPP binout_matsum, contact 19, slave, fx plots negative contact force.

Reversed slave/master notation in legends accordingly.

Preceding paragraph description "(0 for the master side of the interface, 1 for the slave)" is correct.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (3deb5ec) to head (830c56b).
Report is 10 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2280      +/-   ##
==========================================
+ Coverage   83.78%   83.90%   +0.12%     
==========================================
  Files          90       90              
  Lines       10396    10437      +41     
==========================================
+ Hits         8710     8757      +47     
+ Misses       1686     1680       -6     

@PProfizi PProfizi self-requested a review May 13, 2025 08:32
@joshuafairch joshuafairch marked this pull request as ready for review May 13, 2025 12:45
@joshuafairch joshuafairch enabled auto-merge (squash) May 13, 2025 12:47
@joshuafairch joshuafairch changed the title Fix contact force description fix: contact force description May 13, 2025
@joshuafairch joshuafairch changed the title fix: contact force description fix: contact force legend May 13, 2025
@joshuafairch joshuafairch disabled auto-merge May 13, 2025 12:51
@joshuafairch joshuafairch enabled auto-merge (squash) May 13, 2025 12:51
@joshuafairch joshuafairch disabled auto-merge May 13, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant