-
Notifications
You must be signed in to change notification settings - Fork 25
Fix server_to_ansys_grpc_dpf_version due to Packaging 22.0 not recognizing "*" #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So when doing it with 0.7.* what does it do? |
I just updated the description, it does that: |
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 88.15% 88.24% +0.09%
==========================================
Files 69 69
Lines 7760 7760
==========================================
+ Hits 6841 6848 +7
+ Misses 919 912 -7 |
|
Packaging released 22.0 and 0.7.* is not considered as a valid version anymore.
It only affects LegacyGrpcServer.
0.7.* can be replaced by 0.7dev, to ensure we consider all the 0.7.X.devX pre-release versions of ansys-grpc-dpf package.
Here is the testing that has been done for validation:
With packaging==22.0
With packaging==21.3