Fibers 1.0

.clang-format

@@ -11,3 +11,5 @@ AllowShortIfStatementsOnASingleLine: 'true'
 
 # Put escaped newlines into the rightmost column.
 AlignEscapedNewlinesLeft: false
+
+ColumnLimit: 0

.gitignore

@@ -112,3 +112,9 @@ logs/logs.json
 logs/results.json
 .dart_tool/bisect_dart/
 doc/api/
+
+build/
+*.exe
+*.aot
+*.S
+*.s

build-fiber-stress.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+set -e
+
+dart compile aot-snapshot --enable-asserts runtime/tests/vm/dart/fiber/fiber_stress.dart

build-fiber-test.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+set -e
+
+dart compile aot-snapshot --enable-asserts runtime/tests/vm/dart/fiber/fiber_test.dart

build-sdk-debug.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+export CPATH=""
+./tools/build.py -m debug -a x64 runtime dart_precompiled_runtime ddc dartanalyzer analysis_server create_common_sdk create_platform_sdk

build-sdk-product.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+export CPATH=""
+./tools/build.py -m product -a x64 runtime dart_precompiled_runtime ddc dartanalyzer analysis_server create_common_sdk create_platform_sdk

build-sdk-release.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+export CPATH=""
+./tools/build.py -m release -a x64 runtime dart_precompiled_runtime ddc dartanalyzer analysis_server create_common_sdk create_platform_sdk

pkg/analysis_server/lib/src/lsp/semantic_tokens/mapping.dart

@@ -130,13 +130,13 @@ final highlightRegionTokenTypes = {
   HighlightRegionType.IMPORT_PREFIX: SemanticTokenTypes.variable,
   HighlightRegionType.INSTANCE_FIELD_DECLARATION: SemanticTokenTypes.property,
   HighlightRegionType.INSTANCE_FIELD_REFERENCE: SemanticTokenTypes.property,
-  HighlightRegionType.INSTANCE_GETTER_DECLARATION: SemanticTokenTypes.property,
-  HighlightRegionType.INSTANCE_GETTER_REFERENCE: SemanticTokenTypes.property,
+  HighlightRegionType.INSTANCE_GETTER_DECLARATION: SemanticTokenTypes.function,
+  HighlightRegionType.INSTANCE_GETTER_REFERENCE: SemanticTokenTypes.function,
   HighlightRegionType.INSTANCE_METHOD_DECLARATION: SemanticTokenTypes.method,
   HighlightRegionType.INSTANCE_METHOD_REFERENCE: SemanticTokenTypes.method,
   HighlightRegionType.INSTANCE_METHOD_TEAR_OFF: SemanticTokenTypes.method,
-  HighlightRegionType.INSTANCE_SETTER_DECLARATION: SemanticTokenTypes.property,
-  HighlightRegionType.INSTANCE_SETTER_REFERENCE: SemanticTokenTypes.property,
+  HighlightRegionType.INSTANCE_SETTER_DECLARATION: SemanticTokenTypes.function,
+  HighlightRegionType.INSTANCE_SETTER_REFERENCE: SemanticTokenTypes.function,
   HighlightRegionType.KEYWORD: SemanticTokenTypes.keyword,
   HighlightRegionType.LIBRARY_NAME: SemanticTokenTypes.namespace,
   HighlightRegionType.LITERAL_BOOLEAN: CustomSemanticTokenTypes.boolean,
@@ -152,21 +152,21 @@ final highlightRegionTokenTypes = {
   HighlightRegionType.PARAMETER_DECLARATION: SemanticTokenTypes.parameter,
   HighlightRegionType.PARAMETER_REFERENCE: SemanticTokenTypes.parameter,
   HighlightRegionType.STATIC_FIELD_DECLARATION: SemanticTokenTypes.property,
-  HighlightRegionType.STATIC_GETTER_DECLARATION: SemanticTokenTypes.property,
-  HighlightRegionType.STATIC_GETTER_REFERENCE: SemanticTokenTypes.property,
+  HighlightRegionType.STATIC_GETTER_DECLARATION: SemanticTokenTypes.function,
+  HighlightRegionType.STATIC_GETTER_REFERENCE: SemanticTokenTypes.function,
   HighlightRegionType.STATIC_METHOD_DECLARATION: SemanticTokenTypes.method,
   HighlightRegionType.STATIC_METHOD_REFERENCE: SemanticTokenTypes.method,
   HighlightRegionType.STATIC_METHOD_TEAR_OFF: SemanticTokenTypes.method,
-  HighlightRegionType.STATIC_SETTER_DECLARATION: SemanticTokenTypes.property,
-  HighlightRegionType.STATIC_SETTER_REFERENCE: SemanticTokenTypes.property,
+  HighlightRegionType.STATIC_SETTER_DECLARATION: SemanticTokenTypes.function,
+  HighlightRegionType.STATIC_SETTER_REFERENCE: SemanticTokenTypes.function,
   HighlightRegionType.TOP_LEVEL_FUNCTION_DECLARATION:
       SemanticTokenTypes.function,
   HighlightRegionType.TOP_LEVEL_FUNCTION_REFERENCE: SemanticTokenTypes.function,
   HighlightRegionType.TOP_LEVEL_FUNCTION_TEAR_OFF: SemanticTokenTypes.function,
-  HighlightRegionType.TOP_LEVEL_GETTER_DECLARATION: SemanticTokenTypes.property,
-  HighlightRegionType.TOP_LEVEL_GETTER_REFERENCE: SemanticTokenTypes.property,
-  HighlightRegionType.TOP_LEVEL_SETTER_DECLARATION: SemanticTokenTypes.property,
-  HighlightRegionType.TOP_LEVEL_SETTER_REFERENCE: SemanticTokenTypes.property,
+  HighlightRegionType.TOP_LEVEL_GETTER_DECLARATION: SemanticTokenTypes.function,
+  HighlightRegionType.TOP_LEVEL_GETTER_REFERENCE: SemanticTokenTypes.function,
+  HighlightRegionType.TOP_LEVEL_SETTER_DECLARATION: SemanticTokenTypes.function,
+  HighlightRegionType.TOP_LEVEL_SETTER_REFERENCE: SemanticTokenTypes.function,
   HighlightRegionType.TOP_LEVEL_VARIABLE: SemanticTokenTypes.property,
   HighlightRegionType.TOP_LEVEL_VARIABLE_DECLARATION:
       SemanticTokenTypes.property,

pkg/analyzer_cli/tool/perf.dart

@@ -172,6 +172,7 @@ Set<Source?> scanReachableFiles(Uri entryUri) {
     'dart:convert',
     'dart:core',
     'dart:developer',
+    'dart:fiber',
     'dart:_internal',
     'dart:isolate',
     'dart:math',

pkg/dev_compiler/lib/src/kernel/target.dart

@@ -77,6 +77,7 @@ class DevCompilerTarget extends Target {
         'dart:collection',
         'dart:convert',
         'dart:developer',
+        'dart:fiber',
         'dart:io',
         'dart:isolate',
         'dart:js',
@@ -97,6 +98,7 @@ class DevCompilerTarget extends Target {
   @override
   List<String> get extraIndexedLibraries => const [
         'dart:async',
+        'dart:fiber',
         'dart:collection',
         'dart:html',
         'dart:indexed_db',

pkg/front_end/tool/fasta_perf.dart

@@ -124,6 +124,7 @@ Map<Uri, Uint8List> scanReachableFiles(Uri entryUri) {
     Uri.parse('dart:async'),
     Uri.parse('dart:collection'),
     Uri.parse('dart:convert'),
+    Uri.parse('dart:fiber'),
     Uri.parse('dart:core'),
     Uri.parse('dart:developer'),
     Uri.parse('dart:_internal'),

pkg/front_end/tool/perf.dart

@@ -182,6 +182,7 @@ Set<Source> scanReachableFiles(Uri entryUri) {
     'dart:async',
     'dart:collection',
     'dart:convert',
+    'dart:fiber',
     'dart:core',
     'dart:developer',
     'dart:_internal',

pkg/vm/lib/modular/target/dart_runner.dart

@@ -18,6 +18,7 @@ class DartRunnerTarget extends VmTarget {
         'dart:async',
         'dart:collection',
         'dart:convert',
+        'dart:fiber',
         'dart:developer',
         'dart:ffi',
         'dart:_internal',

pkg/vm/lib/modular/target/flutter.dart

@@ -24,6 +24,7 @@ class FlutterTarget extends VmTarget {
         'dart:async',
         'dart:collection',
         'dart:convert',
+        'dart:fiber',
         'dart:developer',
         'dart:ffi',
         'dart:_internal',

pkg/vm/lib/modular/target/flutter_runner.dart

@@ -18,6 +18,7 @@ class FlutterRunnerTarget extends VmTarget {
         'dart:async',
         'dart:collection',
         'dart:convert',
+        'dart:fiber',
         'dart:developer',
         'dart:ffi',
         'dart:_internal',

pkg/vm/lib/modular/target/vm.dart

@@ -76,6 +76,7 @@ class VmTarget extends Target {
         'dart:async',
         'dart:collection',
         'dart:convert',
+        'dart:fiber',
         'dart:developer',
         'dart:ffi',
         'dart:_internal',

runtime/bin/dartutils.cc

@@ -552,6 +552,10 @@ Dart_Handle DartUtils::PrepareCLILibrary(Dart_Handle cli_lib) {
   return Dart_Null();
 }
 
+Dart_Handle DartUtils::PrepareFiberLibrary(Dart_Handle fiber_lib) {
+  return Dart_Null();
+}
+
 Dart_Handle DartUtils::SetupPackageConfig(const char* packages_config) {
   Dart_Handle result = Dart_Null();
 
@@ -578,6 +582,10 @@ Dart_Handle DartUtils::PrepareForScriptLoading(bool is_service_isolate,
   RETURN_IF_ERROR(url);
   Dart_Handle async_lib = Dart_LookupLibrary(url);
   RETURN_IF_ERROR(async_lib);
+  url = NewString(kFiberLibURL);
+  RETURN_IF_ERROR(url);
+  Dart_Handle fiber_lib = Dart_LookupLibrary(url);
+  RETURN_IF_ERROR(fiber_lib);
   url = NewString(kIsolateLibURL);
   RETURN_IF_ERROR(url);
   Dart_Handle isolate_lib = Dart_LookupLibrary(url);
@@ -611,6 +619,7 @@ Dart_Handle DartUtils::PrepareForScriptLoading(bool is_service_isolate,
   RETURN_IF_ERROR(PrepareIsolateLibrary(isolate_lib));
   RETURN_IF_ERROR(PrepareIOLibrary(io_lib));
   RETURN_IF_ERROR(PrepareCLILibrary(cli_lib));
+  RETURN_IF_ERROR(PrepareFiberLibrary(fiber_lib));
   return result;
 }
 

runtime/bin/dartutils.h

@@ -289,6 +289,7 @@ class DartUtils {
 
   static constexpr const char* kDartScheme = "dart:";
   static constexpr const char* kAsyncLibURL = "dart:async";
+  static constexpr const char* kFiberLibURL = "dart:fiber";
   static constexpr const char* kBuiltinLibURL = "dart:_builtin";
   static constexpr const char* kCoreLibURL = "dart:core";
   static constexpr const char* kInternalLibURL = "dart:_internal";
@@ -319,6 +320,7 @@ class DartUtils {
   static Dart_Handle PrepareIOLibrary(Dart_Handle io_lib);
   static Dart_Handle PrepareIsolateLibrary(Dart_Handle isolate_lib);
   static Dart_Handle PrepareCLILibrary(Dart_Handle cli_lib);
+  static Dart_Handle PrepareFiberLibrary(Dart_Handle fiber_lib);
 
   static dart::SimpleHashMap* environment_;
 

runtime/lib/coroutine.cc

@@ -0,0 +1,17 @@
+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include "vm/bootstrap_natives.h"
+
+#include "vm/compiler/runtime_api.h"
+#include "vm/native_entry.h"
+
+namespace dart {
+DEFINE_NATIVE_ENTRY(Coroutine_factory, 0, 3) {
+  GET_NON_NULL_NATIVE_ARGUMENT(Smi, size, arguments->NativeArgAt(1));
+  GET_NON_NULL_NATIVE_ARGUMENT(Closure, trampoline, arguments->NativeArgAt(2));
+  return Coroutine::New(size.Value(), trampoline.function());
+}
+}  // namespace dart
+

runtime/lib/fiber_sources.gni

@@ -0,0 +1 @@
+fiber_runtime_cc_files = [ "coroutine.cc" ]

runtime/lib/isolate.cc

@@ -370,6 +370,7 @@ class MessageValidator : private WorkSet {
           MESSAGE_SNAPSHOT_ILLEGAL(ReceivePort)
           MESSAGE_SNAPSHOT_ILLEGAL(UserTag)
           MESSAGE_SNAPSHOT_ILLEGAL(SuspendState)
+          MESSAGE_SNAPSHOT_ILLEGAL(Coroutine)
         default:
           klass = class_table_->At(cid);
           if (klass.is_isolate_unsendable()) {

runtime/platform/globals.h

@@ -88,8 +88,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <functional>
 #include <sys/types.h>
-
 #include <cassert>  // For assert() in constant expressions.
 
 #if defined(_WIN32)

runtime/tests/vm/dart/fiber/fiber_benchmark.dart

@@ -0,0 +1,38 @@
+import 'dart:fiber';
+
+var iterations = 50000;
+var fibers = 100;
+
+var latency = 0.0;
+
+void main() {
+  Fiber.launch(benchmark);
+}
+
+void benchmark() {
+  final jobs = <Fiber>[];
+  for (var i = 0; i < fibers; i++) {
+    Fiber.schedule(Fiber.current);
+    jobs.add(Fiber.spawn(scheduling));
+  }
+  for (var i = 0; i < fibers; i++) {
+    Fiber.schedule(jobs[i]);
+  }
+  for (var i = 0; i < fibers; i++) {
+    while (!jobs[i].state.disposed) {
+      Fiber.reschedule();
+    }
+  }
+  print("Latency per switch: ${latency / (fibers * iterations * 2)} [micros]");
+}
+
+void scheduling() {
+  Fiber.suspend();
+  final sw = Stopwatch();
+  sw.start();
+  for (var i = 0; i < iterations; i++) {
+    Fiber.reschedule();
+  }
+  sw.stop();
+  latency += sw.elapsedMicroseconds;
+}

runtime/tests/vm/dart/fiber/fiber_captures_suite.dart

@@ -0,0 +1,86 @@
+import 'dart:fiber';
+import 'dart:async';
+import 'package:expect/expect.dart';
+
+final tests = [
+  testGlobalState,
+  testClosureState,
+];
+
+var globalStateValue = "";
+void testGlobalState() {
+  void child() {
+    globalStateValue += "child -> ";
+    Fiber.reschedule();
+    globalStateValue += "child";
+  }
+
+  void main() {
+    globalStateValue = "";
+    globalStateValue += "main -> ";
+    Fiber.schedule(Fiber.current);
+    Fiber.spawn(child);
+    globalStateValue += "main -> ";
+    Fiber.reschedule();
+    Expect.equals("main -> child -> main -> child", globalStateValue);
+  }
+
+  Fiber.launch(main);
+}
+
+void testClosureState() {
+  var localState = "localState";
+  Fiber.launch(
+    () {
+      Expect.equals("localState", localState);
+      localState = "after fiber";
+    },
+  );
+  Expect.equals("after fiber", localState);
+
+  localState = "localState";
+  Fiber.launch(
+    () {
+      Expect.equals("localState", localState);
+      localState = "after main fiber";
+      Fiber.schedule(Fiber.current);
+      Fiber.spawn(
+        () {
+          Expect.equals("after main fiber", localState);
+          localState = "after child fiber";
+          Fiber.reschedule();
+          Expect.equals("after child fiber after main fiber", localState);
+          localState = "finish";
+        },
+        name: "child",
+      );
+      Expect.equals("after child fiber", localState);
+      localState = "after child fiber after main fiber";
+      Fiber.suspend();
+    },
+  );
+  Expect.equals("finish", localState);
+
+  localState = "level 1";
+  Fiber.launch(
+    () {
+      Expect.equals("level 1", localState);
+      localState = "level 2";
+      Fiber.spawn(
+        () {
+          Expect.equals("level 2", localState);
+          localState = "level 3";
+          Fiber.spawn(
+            () {
+              Expect.equals("level 3", localState);
+              localState = "level 4";
+            },
+            name: "child",
+          );
+        },
+        name: "child",
+      );
+    },
+  );
+  Expect.equals("level 4", localState);
+}