Don't resolve URL for non-HTTP strings #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Path is from filesystem, this call will throw an exception. Perhaps there is a different fix for this logic, but this is my first stab at doing so. Feel free to discard.
Personally, I would not feel comfortable merging this PR in without some additional test cases. However, this does fix the problems I was having with using the
openapi-backend
project 🤔Tangent
I noticed the upstream https://apitools.dev/json-schema-ref-parser/ project is looking for new maintainers. I would open an Issue to discuss this, but Issues are not available on this forked repo. @anttiviljami, is it your intent to take over the maintenance of this project (
json-schema-ref-parser
)? I ask because I see a ton of potential inopenapi-backend
, which is dependent onjson-schema-ref-parser
. As such, I am starting to brainstorm approaches around how to best support/contribute to these projects 😀 In this case, if you are planning on maintainingjson-schema-ref-parser
, awesome! If you are not, then I may attempt to get more involved in the maintenance ofjson-schema-ref-parser
myself.Simple Test
The above throws