Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add send_tech theme #1256

Closed
wants to merge 2 commits into from

Conversation

eichenbergerche
Copy link

nice themes, here are my two cents =)

nice themes, here are my two cents =)
@vercel
Copy link

vercel bot commented Aug 16, 2021

@eichenbergerche is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Aug 16, 2021
@anuraghazra
Copy link
Owner

Theme preview (bot)

title_color: #FC784A | icon_color: #F75762 | text_color: #EEEEEE | bg_color: #0d0c2d

Link: https://github-readme-stats.vercel.app/api?username=anuraghazra&title_color=FC784A&icon_color=F75762&text_color=EEEEEE&bg_color=0d0c2d&show_icons=true

Hi thanks for the theme contribution, please read our theme contribution guidelines

We are currently only accepting color combinations from any vscode theme or which has good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use then instead of adding it to our theme collection you can use card customization options

Read our contribution guidelines for more info

@anuraghazra
Copy link
Owner

Theme preview (bot)

title_color: #FC784A | icon_color: #F75762 | text_color: #EEEEEE | bg_color: #0d0c2d

Link: https://github-readme-stats.vercel.app/api?username=anuraghazra&title_color=FC784A&icon_color=F75762&text_color=EEEEEE&bg_color=0d0c2d&show_icons=true

Hi thanks for the theme contribution, please read our theme contribution guidelines

We are currently only accepting color combinations from any vscode theme or which has good color combination to minimize bloating the themes collection.

Also note that if this theme is exclusively for your personal use then instead of adding it to our theme collection you can use card customization options

Read our contribution guidelines for more info

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ send_tech

Result: ✔️ All themes are valid.

Details

Send_tech theme preview

title_color: #FC784A | icon_color: #F75762 | text_color: #EEEEEE | bg_color: #0d0c2d

Preview Link

@rickstaa rickstaa force-pushed the master branch 2 times, most recently from 86aafe8 to 8bc69e7 Compare January 21, 2023 16:47
@rickstaa rickstaa mentioned this pull request May 9, 2023
@rickstaa rickstaa added ⭐ top themes Top themes and removed ⭐ top themes Top themes labels May 9, 2023
@rickstaa rickstaa added the ⭐ top pull request Top pull request. label Jun 15, 2023
@github-actions github-actions bot added ⭐ top pull request Top pull request. and removed ⭐ top pull request Top pull request. labels Jun 15, 2023
@github-actions
Copy link
Contributor

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

Warning

Keep in mind that we already have a vast collection of different themes. To keep their number manageable, we began to add only themes supported by the community. Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up (see #1935). Remember that you can also support themes of other contributors that you liked to speed up their merge.

Note

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ send_tech

Result: ✔️ All themes are valid.

Details

Send_tech theme preview

title_color: #FC784A | icon_color: #F75762 | text_color: #EEEEEE | bg_color: #0d0c2d

Preview Link

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (92518e3) 97.71% compared to head (f068690) 97.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          24       24           
  Lines        5076     5082    +6     
  Branches      451      451           
=======================================
+ Hits         4960     4966    +6     
  Misses        115      115           
  Partials        1        1           
Impacted Files Coverage Δ
themes/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice theme! I have resolved conflicts with master branch to be able to merge this PR after it receive enough community support.

@rickstaa We have already decided that the decision to merge themes is based on feedback from the community, but we have not decided on the specific number of thumbs up that a pull request should receive in order to be considered that the community supported it. What do you think?

@github-actions github-actions bot removed the ⭐ top pull request Top pull request. label Aug 25, 2023
@github-actions github-actions bot added ⭐ top pull request Top pull request. and removed ⭐ top pull request Top pull request. labels Sep 22, 2023
@github-actions github-actions bot removed the ⭐ top themes Top themes label Oct 22, 2023
@anuraghazra
Copy link
Owner

We are currently pausing addition of new themes. If this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants