-
-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add send_tech theme #1256
add send_tech theme #1256
Conversation
nice themes, here are my two cents =)
@eichenbergerche is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Theme preview (bot) title_color:
|
Theme preview (bot) title_color:
|
Automated Theme PreviewHi, thanks for the theme contribution. Please read our theme contribution guidelines. We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.
✔️ Theme PR does adhere to our guidelines. Test results
Result: ✔️ All themes are valid. DetailsSend_tech theme previewtitle_color: |
86aafe8
to
8bc69e7
Compare
Automated Theme PreviewHi, thanks for the theme contribution. Please read our theme contribution guidelines.
✔️ Theme PR does adhere to our guidelines. Test results
Result: ✔️ All themes are valid. DetailsSend_tech theme previewtitle_color: |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 24 24
Lines 5076 5082 +6
Branches 451 451
=======================================
+ Hits 4960 4966 +6
Misses 115 115
Partials 1 1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice theme! I have resolved conflicts with master branch to be able to merge this PR after it receive enough community support.
@rickstaa We have already decided that the decision to merge themes is based on feedback from the community, but we have not decided on the specific number of thumbs up that a pull request should receive in order to be considered that the community supported it. What do you think?
We are currently pausing addition of new themes. If this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options. |
nice themes, here are my two cents =)