Feature/grs 1955 change commonjs imports #1995
Conversation
|
@rsk2 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
card-i18n
This commit makes sure jest is set-up to support es6. It also fixes several test errors and sorts the imports.
|
@rsk2 I checked this PR, and something weird is happening. It looks like not all changes in https://github.com/rsk2/github-readme-stats/pull/1/files are found in this PR. I think this is because merge conflicts in 275ec70 were not correctly dealt with.
Still is
Which is incorrect and will throw an error. |
|
I fixed the merge conflicts with a force push (see https://github.com/anuraghazra/github-readme-stats/compare/275ec7001b4ba1d055be692f43e59fe3c52fa3b9..0b3f701c005228c8723918aeea34f25ede6166ad). |
This commit makes sure node 16 is used in the github actions.
Codecov ReportBase: 95.20% // Head: 94.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1995 +/- ##
==========================================
- Coverage 95.20% 94.66% -0.54%
==========================================
Files 22 22
Lines 792 712 -80
Branches 219 219
==========================================
- Hits 754 674 -80
Misses 33 33
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
All problems are fixed now. @rsk2 Thanks a lot for your contribution! 🚀 It greatly improves the codebase. |
|
Thanks for your help and guidance @rickstaa! |
* GRS-1955: Using ES6 import/export in src files * GRS-1955: Using ES6 import/export in test files * GRS-1955: Using ES6 import/export in themes index.js * GRS-1955: Readding blank line at end of top-languages-card.js * feat: fix test es6 import errors This commit makes sure jest is set-up to support es6. It also fixes several test errors and sorts the imports. * test: update test node version This commit makes sure node 16 is used in the github actions. * refactor: run prettier Co-authored-by: rickstaa <[email protected]>
* GRS-1955: Using ES6 import/export in src files * GRS-1955: Using ES6 import/export in test files * GRS-1955: Using ES6 import/export in themes index.js * GRS-1955: Readding blank line at end of top-languages-card.js * feat: fix test es6 import errors This commit makes sure jest is set-up to support es6. It also fixes several test errors and sorts the imports. * test: update test node version This commit makes sure node 16 is used in the github actions. * refactor: run prettier Co-authored-by: rickstaa <[email protected]>
No description provided.