Skip to content

Accurate GitHub Dark Theme #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Accurate GitHub Dark Theme #1996

wants to merge 1 commit into from

Conversation

intergrav
Copy link

@intergrav intergrav commented Sep 3, 2022

This adds a more accurate GitHub dark theme. The other one is nice, but doesn't really fit as well as this one.

image

@vercel
Copy link

vercel bot commented Sep 3, 2022

@intergrav is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Sep 3, 2022
@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ accurate_github_dark

Result: ✔️ All themes are valid.

Details

Accurate_github_dark theme preview

title_color: #c9d1d9 | icon_color: #8b949e | text_color: #8b949e | bg_color: #0d1117 | border_color: #30363d

Preview Link

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ accurate_github_dark

Result: ✔️ All themes are valid.

Details

Accurate_github_dark theme preview

title_color: #c9d1d9 | icon_color: #8b949e | text_color: #8b949e | bg_color: #0d1117 | border_color: #30363d

Preview Link

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ accurate_github_dark

Result: ✔️ All themes are valid.

Details

Accurate_github_dark theme preview

title_color: #c9d1d9 | icon_color: #8b949e | text_color: #8b949e | bg_color: #0d1117 | border_color: #30363d

Preview Link

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 2, 2022

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ accurate_github_dark

Result: ✔️ All themes are valid.

Details

Accurate_github_dark theme preview

title_color: #c9d1d9 | icon_color: #8b949e | text_color: #8b949e | bg_color: #0d1117 | border_color: #30363d

Preview Link

@rickstaa rickstaa force-pushed the master branch 2 times, most recently from 86aafe8 to 8bc69e7 Compare January 21, 2023 16:47
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: Not Found

@github-actions github-actions bot added the invalid The bug/issue caused by minor mistakes. label Mar 4, 2023
@Zo-Bro-23
Copy link
Collaborator

Zo-Bro-23 commented Mar 5, 2023

I like this theme. @rickstaa what do you think?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: Not Found

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: Not Found

Copy link
Collaborator

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: Not Found

Copy link
Collaborator

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong in the theme preview action: Not Found

@rickstaa
Copy link
Collaborator

rickstaa commented Mar 5, 2023

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ accurate_github_dark

Result: ✔️ All themes are valid.

Details

Accurate_github_dark theme preview

title_color: #c9d1d9 | icon_color: #8b949e | text_color: #8b949e | bg_color: #0d1117 | border_color: #30363d

Preview Link

@rickstaa rickstaa removed the invalid The bug/issue caused by minor mistakes. label Mar 5, 2023
@rickstaa
Copy link
Collaborator

rickstaa commented Mar 5, 2023

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ accurate_github_dark

Result: ✔️ All themes are valid.

Details

Accurate_github_dark theme preview

title_color: #c9d1d9 | icon_color: #8b949e | text_color: #8b949e | bg_color: #0d1117 | border_color: #30363d

Preview Link

@rickstaa
Copy link
Collaborator

rickstaa commented Mar 5, 2023

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ accurate_github_dark

Result: ✔️ All themes are valid.

Details

Accurate_github_dark theme preview

title_color: #c9d1d9 | icon_color: #8b949e | text_color: #8b949e | bg_color: #0d1117 | border_color: #30363d

Preview Link

@rickstaa
Copy link
Collaborator

rickstaa commented Mar 5, 2023

@Zo-Bro-23 I fixed the theme preview action again (see #2566). About this theme; I agree it is a nice theme. I however am curious why why @intergrav thinks this theme is a more accurate version of the github_dark theme we already have that was added in #758. I think that theme represents the GitHub Dark theme very well.

Anurag's GitHub stats

image

@Zo-Bro-23
Copy link
Collaborator

Zo-Bro-23 commented Mar 5, 2023

Agreed. The text/icon/title colors just seem a bit weird because GitHub doesn't use them anywhere, and the new colors match what GitHub uses, but on closer inspection, the existing theme is good enough. Closing this for now.

@Zo-Bro-23 Zo-Bro-23 closed this Mar 5, 2023
@intergrav
Copy link
Author

yeah it's fine, i hadn't realized you could set your own custom colors manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants