Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #764: Add custom year #2107
base: master
Are you sure you want to change the base?
Issue #764: Add custom year #2107
Changes from 9 commits
ecfd948
c0ec7fc
d2c4dfd
4b15721
b74d5be
a8f8bdf
6fa5759
150e13a
15f9303
afb417b
eb445fa
af6553e
de4cefa
d7dd5b5
573af5d
1939ffd
4678af5
5b65614
03366e5
0c3d572
b24733a
4adc788
e729141
7c30597
94d9612
e53a04e
4c3629b
b60aa8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the other test, which tested whether the current year is returned when no year is supplied. I did this because this is already tested in:
github-readme-stats/tests/fetchStats.test.js
Line 127 in af6553e
github-readme-stats/tests/fetchStats.test.js
Line 216 in af6553e
and
github-readme-stats/tests/fetchStats.test.js
Line 191 in af6553e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anuraghazra, are you okay with this implicit testing, or do you want to have an explicit test like @vzsky did in
github-readme-stats/tests/fetchStats.test.js
Line 193 in 4b15721
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that just to be sure that the mocked function works fine. I think deleting that is probably okay since the mocked function was tested and is not likely to get changed.