Skip to content

Refactor: Fix docstring for getCardColors utils function #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qwerty541
Copy link
Collaborator

No description provided.

@qwerty541 qwerty541 requested a review from rickstaa July 29, 2023 20:05
@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Jul 29, 2023 8:05pm

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0f8a790) 97.63% compared to head (be50c30) 97.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3011   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          24       24           
  Lines        5198     5203    +5     
  Branches      464      464           
=======================================
+ Hits         5075     5080    +5     
  Misses        122      122           
  Partials        1        1           
Files Changed Coverage Δ
src/common/utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickstaa
Copy link
Collaborator

@qwerty541 Thanks again for improving the TS compatibility of this repository. It makes it a lot easier to develop the project 🚀.

@rickstaa rickstaa merged commit ffafcf2 into master Jul 30, 2023
@rickstaa rickstaa deleted the refactor_fix_docstring_for_getCardColors_utils_func branch July 30, 2023 10:08
Copy link
Collaborator Author

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwerty541 Thanks again for improving the TS compatibility of this repository. It makes it a lot easier to develop the project 🚀.

@rickstaa Strategic goal of all this pull requests which improves TS compatibility is future complete migration on typescript. I think that this migration should be much easier and contain less code updates if code will be TS compatible.

@rickstaa
Copy link
Collaborator

@qwerty541 Thanks again for improving the TS compatibility of this repository. It makes it a lot easier to develop the project 🚀.

@rickstaa Strategic goal of all this pull requests which improves TS compatibility is future complete migration on typescript. I think that this migration should be much easier and contain less code updates if code will be TS compatible.

Full migration in the future would be amazing 👍🏻.

phamleduy04 pushed a commit to phamleduy04/github-readme-stats that referenced this pull request Aug 5, 2023
* Refactor: Wakatime card: Add missing return statements for helper functions (anuraghazra#2998)

* Refactor: Wakatime card: Add missing return statements for helper functions

* dev

* Refactor: Repo card: Fixed type error in iconWithLabel function (anuraghazra#2999)

* Refactor: Improve docstring for lowercaseTrim utils function (anuraghazra#3002)

* Refactor: Improve docstring for dateDiff utils function (anuraghazra#3001)

* CI: skx/github-action-tester dependency pinned by hash (anuraghazra#3014)

* Refactor: Fix MissingParamError class constructor docstring (anuraghazra#3012)

* Refactor: Fix docstring for getCardColors utils function (anuraghazra#3011)

* I10n: Add partially-missing Uzbek translations (anuraghazra#3018)

* Stats card: Add Uzbek to long languages (anuraghazra#3019)

* Docs: Add security policy (anuraghazra#2908)

* Build(deps-dev): Bump jest from 29.6.1 to 29.6.2 (anuraghazra#3026)

Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 29.6.1 to 29.6.2.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v29.6.2/packages/jest)

---
updated-dependencies:
- dependency-name: jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexandr <[email protected]>

* Build(deps-dev): Bump eslint from 8.45.0 to 8.46.0 (anuraghazra#3025)

Bumps [eslint](https://github.com/eslint/eslint) from 8.45.0 to 8.46.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.45.0...v8.46.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alexandr <[email protected]>

* Build(deps-dev): Bump eslint-config-prettier from 8.8.0 to 8.9.0 (anuraghazra#3027)

Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.8.0 to 8.9.0.
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v8.8.0...v8.9.0)

---
updated-dependencies:
- dependency-name: eslint-config-prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Build(deps-dev): Bump jest-environment-jsdom from 29.6.1 to 29.6.2 (anuraghazra#3024)

Bumps [jest-environment-jsdom](https://github.com/facebook/jest/tree/HEAD/packages/jest-environment-jsdom) from 29.6.1 to 29.6.2.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v29.6.2/packages/jest-environment-jsdom)

---
updated-dependencies:
- dependency-name: jest-environment-jsdom
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Build(deps): Bump rickstaa/top-issues-action from 1.3.29 to 1.3.32 (anuraghazra#3023)

Bumps [rickstaa/top-issues-action](https://github.com/rickstaa/top-issues-action) from 1.3.29 to 1.3.32.
- [Release notes](https://github.com/rickstaa/top-issues-action/releases)
- [Commits](rickstaa/top-issues-action@f31962c...c66e5d5)

---
updated-dependencies:
- dependency-name: rickstaa/top-issues-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Build(deps): Bump github/codeql-action from 2.21.0 to 2.21.2 (anuraghazra#3022)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.0 to 2.21.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@1813ca7...0ba4244)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Build(deps): Bump rickstaa/empty-issues-closer-action (anuraghazra#3021)

Bumps [rickstaa/empty-issues-closer-action](https://github.com/rickstaa/empty-issues-closer-action) from 1.1.0 to 1.1.2.
- [Release notes](https://github.com/rickstaa/empty-issues-closer-action/releases)
- [Commits](rickstaa/empty-issues-closer-action@773bc31...09d48db)

---
updated-dependencies:
- dependency-name: rickstaa/empty-issues-closer-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* CI: Fix theme preview workflow (anuraghazra#3017)

* Refactor: Fix docstring for rankIcon function (anuraghazra#3029)

* CI: Add SECURITY.md to pull requests labeler (anuraghazra#3030)

* Refactor: Wakatime card: Add missing returns statement for createTextNode function (anuraghazra#3032)

* Refactor: Wakatime card: Use @typedef to resolve eslint errors (anuraghazra#3033)

* CI: Fix theme preview workflow (Attempt 2) (anuraghazra#3034)

* Themes: Add test AI-generated themes to check preview workflow (anuraghazra#3028)

* Themes: Add test theme to check preview workflow

* dev

* dev

* dev

* docs(theme): Auto update theme readme (anuraghazra#3038)

Co-authored-by: GitHub Readme Stats Bot <[email protected]>

* Refactor: Wakatime card: Use typedef tags to resolve eslint errors (anuraghazra#3037)

* Refactor: Top langs card: Fix returns tag in docstrings (anuraghazra#3036)

* Refactor: Stats card: Use typedef tags to resolve eslint errors (anuraghazra#3039)

* Refactor: Top langs card: Use typedef tags to resolve eslint errors (anuraghazra#3040)

* Refactor: Repo card: Use typedef tags inside data fetcher to resolve eslint errors (anuraghazra#3043)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Alexandr Garbuzov <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub Readme Stats Bot <[email protected]>
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
ABA2396 pushed a commit to ABA2396/github-readme-stats that referenced this pull request Dec 22, 2023
ABA2396 pushed a commit to ABA2396/github-readme-stats that referenced this pull request Dec 22, 2023
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
necofuryai added a commit to necofuryai/github-readme-stats that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants