Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

feat: migrate scatterplot to use encodable #421

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Apr 2, 2020

🏆 Enhancements

Migrate to use encodable package.

@kristw kristw requested a review from a team as a code owner April 2, 2020 23:34
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #421 into kristw--feature-encodable will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           kristw--feature-encodable    #421   +/-   ##
=========================================================
  Coverage                       3.33%   3.33%           
=========================================================
  Files                            194     194           
  Lines                           5944    5934   -10     
  Branches                         451     447    -4     
=========================================================
  Hits                             198     198           
+ Misses                          5705    5695   -10     
  Partials                          41      41           
Impacted Files Coverage Δ
...hart-xy/src/ScatterPlot/DefaultTooltipRenderer.tsx 0.00% <ø> (ø)
...rset-ui-preset-chart-xy/src/ScatterPlot/Encoder.ts 0.00% <0.00%> (ø)
...ui-preset-chart-xy/src/ScatterPlot/ScatterPlot.tsx 0.00% <0.00%> (ø)
...rt-xy/src/components/legend2/DefaultLegendItem.tsx 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3cc3f9...7d17e39. Read the comment docs.

@kristw kristw force-pushed the kristw--encodable-scatter branch from d660305 to 7d17e39 Compare April 2, 2020 23:42
@kristw kristw merged commit 95fee50 into kristw--feature-encodable Apr 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--encodable-scatter branch April 2, 2020 23:54
kristw added a commit that referenced this pull request Apr 15, 2020
* feat: migrate scatter plot

(cherry picked from commit 0d607a6)

* fix: legend
kristw added a commit that referenced this pull request Apr 17, 2020
* feat: migrate xy-chart to use encodable (#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a6)

* fix: legend

* feat: migrate line chart to use encodable (#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
* feat: migrate xy-chart to use encodable (apache-superset#420)

* feat: use encodable in BoxPlot

* feat: migrate legend

* docs: update storybook

* fix: label overlap

* fix: lint

* fix: remove comments

* fix: path

* feat: migrate scatterplot to use encodable (apache-superset#421)

* feat: migrate scatter plot

(cherry picked from commit 0d607a6)

* fix: legend

* feat: migrate line chart to use encodable (apache-superset#427)

* feat: migrate line to use encodable

* fix: storybook ts

* fix: remove comment

* refactor: delete deprecated files (apache-superset#430)

* refactor: delete outdated files

* feat: update index exports and add test

* refactor: delete more files

* fix: import order

* fix: update dependency

* fix: update dependency

* build: fix babel

* fix: remvoe comments

* fix: babel

* refactor: move files (apache-superset#432)

* refactor: move files

* refactor: move files

* fix: small issues with charts post-migration (apache-superset#433)

* fix: scatterplot issue

* fix: bump encodable and fix time scale nicing

* fix: issue with label rotation

* refactor: remove deep import

* fix: demo import

* feat: bump and remove unnecessary dependencies (apache-superset#436)

* feat: bump dependencies

* feat: remove unnecessary dependencies
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant