Skip to content

Tags with special characters #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mortenbirkelund opened this issue Dec 21, 2023 · 4 comments · Fixed by #693
Closed

Tags with special characters #692

mortenbirkelund opened this issue Dec 21, 2023 · 4 comments · Fixed by #693
Labels
bug Something isn't working

Comments

@mortenbirkelund
Copy link

Describe the bug
Special characters in tags causes answer to assume incorrect urls. For instance a forward slash will be accepted in the tag, which obviously causes a problem in a url

To Reproduce
Steps to reproduce the behavior:

  1. Create a tag with a forward slash "Something / something"
  2. See that the url that answer uses for the tag is https://yourdomain/tags/Something-/-something
  3. Try and visit this url, and you will get a 404

Expected behavior
I expected that answer will either not allow special characters when creating tag, or would url-encode before creating the url.

Screenshots
NIL

@mortenbirkelund mortenbirkelund added the bug Something isn't working label Dec 21, 2023
@shuashuai
Copy link
Member

In response to this situation, we have made a repair in V1.2.1, and special characters will be escaped in 1.2.1. this version will be released soon.

In 1.2.1, the url will be displayed like this /tags/something-%2F-something.

@sy-records
Copy link
Member

@fenbox
Copy link
Member

fenbox commented Dec 21, 2023

@sy-records May be we need remove the prompt message.

@shuashuai
Copy link
Member

While escaping works, it doesn't seem to match the prompt message.

https://github.com/apache/incubator-answer/blob/82fdfc77636d8d1ce28710d929a8c22bb52834ef/i18n/en_US.yaml#L733-L735

We ignored the prompt message for editing the tag when modifying the condition. The latest news should be

image

The prompt message you marked should be consistent with the above. Maybe you can help us fix the prompt message!

shuashuai pushed a commit that referenced this issue Dec 25, 2023
close #692 

There are several languages that require specialized translators. 😅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants