Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update admin name validation #1276

Merged
merged 2 commits into from
Mar 17, 2025
Merged

fix: update admin name validation #1276

merged 2 commits into from
Mar 17, 2025
+10 −9

Conversation

sy-records
Copy link
Member

Close #1273

@LinkinStars LinkinStars requested a review from shuashuai March 12, 2025 03:04
@shuashuai
Copy link
Member

Close #1273

According to @fenbox's description, the checksum rule here should be wrong, in this case it's the name and not the username!

It should be consistent with the rules for the name on the registration page.

image

@sy-records sy-records marked this pull request as draft March 14, 2025 07:47
@sy-records sy-records changed the title refactor: rename admin_name to admin_username fix: update admin name validation Mar 14, 2025
@sy-records sy-records marked this pull request as ready for review March 14, 2025 10:08
shuashuai
shuashuai approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shuashuai shuashuai added this to the v1.4.5 milestone Mar 17, 2025
@shuashuai shuashuai merged commit cd24c91 into apache:dev Mar 17, 2025
@sy-records sy-records deleted the refactor/install branch March 17, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuashuai shuashuai shuashuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@sy-records @shuashuai