Skip to content

fix #587 #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 29, 2023
Merged

fix #587 #621

merged 19 commits into from
Nov 29, 2023

Conversation

shubo83
Copy link

@shubo83 shubo83 commented Nov 11, 2023

  1. query for synonyms and get the corresponding mainTagIds.
  2. add ID in condition to the main query statement.

kelvinkuo and others added 3 commits November 10, 2023 12:16
use `Link` instead of `<a>` tag to prevent wrong link in this situation

www.xxx.com/answer/
@LinkinStars
Copy link
Member

  1. You can refer this issue. support tag search for synonyms #618 (comment)
  2. Remove that the print log code fmt.Println.

remove print log code `fmt.Println`
@LinkinStars
Copy link
Member

I noticed you changed the code, but there are still some issues. You can test it by following steps.

  1. Add two tags a and b
  2. Set b to be a synonym for a
  3. Use b for querying via api

You'll notice that the a tag still doesn't appear in the query result. It doesn't solve the issue of #587 .

@shubo83
Copy link
Author

shubo83 commented Nov 14, 2023

I noticed you changed the code, but there are still some issues. You can test it by following steps.

  1. Add two tags a and b
  2. Set b to be a synonym for a
  3. Use b for querying via api

You'll notice that the a tag still doesn't appear in the query result. It doesn't solve the issue of #587 .

ok, I'll try to debug it.

@shubo83
Copy link
Author

shubo83 commented Nov 14, 2023

I noticed you changed the code, but there are still some issues. You can test it by following steps.

  1. Add two tags a and b
  2. Set b to be a synonym for a
  3. Use b for querying via api

You'll notice that the a tag still doesn't appear in the query result. It doesn't solve the issue of #587 .

I followed your three steps to test, and there was no problem. As shown below:

image image

Strange, where is the problem?

shubo83 and others added 6 commits November 14, 2023 16:56
Query for the main tag ID, make up for error handling.
Fix time format problem in **de-DE**
The files that in the `docs/release` will be pack into binary release
zip.

- [x] put all the dependency licenses into `docs/release/licenses`.
- [x] add LICENSE for release binary. (We need to check this format
whether meet the requirements or not.)
- [x] add NOTICE for release binary.

---------

Co-authored-by: tison <[email protected]>
Co-authored-by: shuai <[email protected]>
@LinkinStars LinkinStars self-assigned this Nov 17, 2023
@LinkinStars LinkinStars added this to the v1.2.1 milestone Nov 17, 2023
@LinkinStars LinkinStars changed the base branch from main to feat/1.2.1/dashboard November 29, 2023 08:20
@LinkinStars LinkinStars merged commit fec5bec into apache:feat/1.2.1/dashboard Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants