fix: permalink error on some pages #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sy-records
force-pushed
the
fix/permalink
branch
2 times, most recently
from
aa3363c to
07cb4ee
Compare
LinkinStars
requested changes
Nov 28, 2023
internal/schema/question_schema.go
Outdated
Comment on lines
207
to
211
| Title string `json:"title" xorm:"title"` // title | ||
| UrlTitle string `json:"url_title" xorm:"url_title"` // title | ||
| ViewCount int `json:"view_count" xorm:"view_count"` // view count | ||
| AnswerCount int `json:"answer_count" xorm:"answer_count"` // answer count | ||
| CollectionCount int `json:"collection_count" xorm:"collection_count"` // collection count |
There was a problem hiding this comment.
The xorm tag here must have been misused by someone else, please help me remove it. And remove the final comments, which are redundant. Thanks a lot.
There was a problem hiding this comment.
Remove all xorm tags?
There was a problem hiding this comment.
Remove all xorm tags?
Yes. In this struct.
| @@ -591,8 +591,13 @@ func (qs *QuestionCommon) ShowListFormat(ctx context.Context, data *entity.Quest | |||
| } | |||
|
|
|||
| func (qs *QuestionCommon) ShowFormat(ctx context.Context, data *entity.Question) *schema.QuestionInfo { | |||
| ID := data.ID | |||
There was a problem hiding this comment.
Using id for variable name would be better.
LinkinStars
reviewed
Nov 28, 2023
Comment on lines
594
to
600
| var ID = data.ID | ||
| if handler.GetEnableShortID(ctx) { | ||
| ID = uid.EnShortID(data.ID) | ||
| } | ||
|
|
||
| info := schema.QuestionInfo{} | ||
| info.ID = data.ID | ||
| info.ID = ID |
There was a problem hiding this comment.
Wouldn't that be better?
info := schema.QuestionInfo{}
info.ID = data.ID
if handler.GetEnableShortID(ctx) {
info.ID = uid.EnShortID(data.ID)
}
shuashuai
approved these changes
Nov 28, 2023
sy-records
force-pushed
the
fix/permalink
branch
from
69363cd to
bf2d316
Compare
LinkinStars
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #656