Skip to content

fix: the answer's content in edit answer page disappears #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

hgaol
Copy link
Member

@hgaol hgaol commented Jan 9, 2024

fix #713 .

After changing to useEffect, the issue was resolved. I don't know why we use useLayoutEffect. Pls let me know if something I missed.

@LinkinStars LinkinStars requested a review from shuashuai January 9, 2024 13:52
Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that useLayoutEffect is causing this bug, and it's related to the logic we used to refactor the editor's core functionality; thanks for contributing!

I will also check the logic of all used useLayoutEffect in V.1.2.5.

@shuashuai shuashuai merged commit 1b1c994 into apache:dev Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants