Build failed after clock changed to daylight saving time

[weizhouapache]

problem

got this exception

[ERROR] Tests run: 47, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.506 s <<< FAILURE! - in org.apache.cloudstack.resource.ResourceCleanupServiceImplTest
[ERROR] testCalculatePastDateFromConfig(org.apache.cloudstack.resource.ResourceCleanupServiceImplTest)  Time elapsed: 0.004 s  <<< FAILURE!
java.lang.AssertionError: expected:<10> but was:<9>
	at org.apache.cloudstack.resource.ResourceCleanupServiceImplTest.testCalculatePastDateFromConfig(ResourceCleanupServiceImplTest.java:634)

versions

4.20/4.21

The steps to reproduce the bug

No response

What to do about it?

No response

[DaanHoogland]

@wei, was this after or during clock change? can you reproduce?

[weizhouapache]

@wei, was this after or during clock change? can you reproduce?

yes, actually it happened in my laptop in the past week. I had to skip the tests during building/packaging
today the issue is gone, because 10 days has past.

If I change the days to 20, then the issue is back

cloudstack/server/src/test/java/org/apache/cloudstack/resource/ResourceCleanupServiceImplTest.java

Lines 626 to 635 in 4c31f9d

	@Test
	public void testCalculatePastDateFromConfig() {
	int days = 10;
	Date result = resourceCleanupService.calculatePastDateFromConfig(
	ResourceCleanupService.ExpungedResourcesPurgeKeepPastDays.key(),
	days);
	Date today = new Date();
	long diff = today.getTime() - result.getTime();
	Assert.assertEquals(days, TimeUnit.DAYS.convert(diff, TimeUnit.MILLISECONDS));
	}

[INFO] Running org.apache.cloudstack.resource.ResourceCleanupServiceImplTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[ERROR] Tests run: 47, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.255 s <<< FAILURE! - in org.apache.cloudstack.resource.ResourceCleanupServiceImplTest
[ERROR] testCalculatePastDateFromConfig(org.apache.cloudstack.resource.ResourceCleanupServiceImplTest)  Time elapsed: 0.004 s  <<< FAILURE!
java.lang.AssertionError: expected:<20> but was:<19>
	at org.apache.cloudstack.resource.ResourceCleanupServiceImplTest.testCalculatePastDateFromConfig(ResourceCleanupServiceImplTest.java:634)

[DaanHoogland]

ok, seems like a unit-test intelligence issue. I have no lower Severity than trivial ;) we'll encounter this end of october again , i guess.

[weizhouapache]

ok, seems like a unit-test intelligence issue. I have no lower Severity than trivial ;) we'll encounter this end of october again , i guess.

normally the diff is 10 days

in the past week, the diff was 10 days -1 hour
in october, it will be 10 days+ 1 hour, so it might be ok. I am not sure

[DaanHoogland]

ok, seems like a unit-test intelligence issue. I have no lower Severity than trivial ;) we'll encounter this end of october again , i guess.

normally the diff is 10 days

in the past week, the diff was 10 days -1 hour in october, it will be 10 days+ 1 hour, so it might be ok. I am not sure

ok, but then the bug will be back next end of march/beginning of april, so it remains a low prio issue for ci-ish kind of envs.