-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: show checksum field when register or upload template/isos #10725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: show checksum field when register or upload template/isos #10725
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10725 +/- ##
=========================================
Coverage 15.17% 15.17%
- Complexity 11332 11337 +5
=========================================
Files 5415 5415
Lines 474893 474893
Branches 57920 57920
=========================================
+ Hits 72046 72058 +12
+ Misses 394792 394775 -17
- Partials 8055 8060 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but one question: what would be the significance of allowed
?
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
have you checked #10193 ? @DaanHoogland |
yes, |
some fields (xenserver tools version) are only allowed for root admin. |
code LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked in qa
Description
This PR fixes #9843
note: check on
allowed
has been removed in #10193Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?