-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Create an easy way to enable Java remote Debug for ACS #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The idea is to create a property in /etc/defaults/cloudstack-management that can be enabled/disabled (uncommented/commented) to control the enabling of Java remote debug in CloudStack's JVM.
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1874 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rafael. Code LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks!
Do you guys think that we need to document this somewhere? Or is it ok to leave it as is? |
nice, I would say put it on the wiki in th dev 1o1 tree. We don't have dev docs, persé |
Done. Shall we execute tests before merging? |
ci has been executed and the fix is on functional. it is only documentation in code, i think we're fine, @rafaelweingartner . |
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1879 |
This PR is an extension of apache#2535. By doing this, we also create an easy method to enable remote debug in CentOS63 as well.
This PR is an extension of #2535. By doing this, we also create an easy method to enable remote debug in CentOS63 as well.
Description
The idea is to create a property in /etc/defaults/cloudstack-management that can be enabled/disabled (uncommented/commented) to control the enabling of Java remote debug in CloudStack's JVM.
Types of changes
How Has This Been Tested?
Locally in my test environment. I applied this PR into my local ACS, and then checked if the remote debug using port 8000 would be available by uncommenting the 'JAVA_DEBUG' declaration in /etc/defaults/cloudstack-management. After uncommenting the variable I needed to restart the management server.
Checklist:
Testing
@blueorangutan package