Skip to content

Create an easy way to enable Java remote Debug for ACS #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

rafaelweingartner
Copy link
Member

@rafaelweingartner rafaelweingartner commented Apr 5, 2018

Description

The idea is to create a property in /etc/defaults/cloudstack-management that can be enabled/disabled (uncommented/commented) to control the enabling of Java remote debug in CloudStack's JVM.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

Locally in my test environment. I applied this PR into my local ACS, and then checked if the remote debug using port 8000 would be available by uncommenting the 'JAVA_DEBUG' declaration in /etc/defaults/cloudstack-management. After uncommenting the variable I needed to restart the management server.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@blueorangutan package

The idea is to create a property in /etc/defaults/cloudstack-management that can be enabled/disabled (uncommented/commented) to control the enabling of Java remote debug in CloudStack's JVM.
@rafaelweingartner rafaelweingartner self-assigned this Apr 5, 2018
@rafaelweingartner rafaelweingartner changed the title Create an easy way to enable the Java remote Debug for ACS Create an easy way to enable Java remote Debug for ACS Apr 5, 2018
@rafaelweingartner rafaelweingartner added this to the 4.12.0.0 milestone Apr 5, 2018
@blueorangutan
Copy link

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1874

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice change.

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rafael. Code LGTM!

Copy link
Contributor

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@rafaelweingartner
Copy link
Member Author

Do you guys think that we need to document this somewhere? Or is it ok to leave it as is?

@DaanHoogland
Copy link
Contributor

nice, I would say put it on the wiki in th dev 1o1 tree. We don't have dev docs, persé

@rafaelweingartner
Copy link
Member Author

Done.

Shall we execute tests before merging?

@DaanHoogland
Copy link
Contributor

ci has been executed and the fix is on functional. it is only documentation in code, i think we're fine, @rafaelweingartner .

@rafaelweingartner rafaelweingartner merged commit e198ff2 into apache:master Apr 6, 2018
@blueorangutan
Copy link

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1879

rafaelweingartner added a commit to rafaelweingartner/cloudstack that referenced this pull request Jan 12, 2019
This PR is an extension of apache#2535. By doing this, we also create an easy method to enable remote debug in CentOS63 as well.
rafaelweingartner added a commit that referenced this pull request Jan 15, 2019
This PR is an extension of #2535. By doing this, we also create an easy method to enable remote debug in CentOS63 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants