Skip to content

linstor: fix template copy on non hyperconverged setups #8114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

linstor: fix template copy on non hyperconverged setups #8114

merged 1 commit into from
Oct 19, 2023

Conversation

rp-
Copy link
Contributor

@rp- rp- commented Oct 18, 2023

Description

Making a diskful resource was meant as an optimization, but cannot work on non hyperconverged setups,
as the storage nodes (diskful) are not part of the cloudstack cluster.

This was introduced with 4a86a0d, so it isn't in any released version yet.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER for non hyperconverged setups
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested on a new non hyperconverged cluster setup

How did you try to break this feature and the system with this change?

@rp-
linstor: fix template copy on non hyperconverged setups
938f348 
Making a diskful resource was meant as an optimization,
but cannot work on non hyperconverged setups,
as the storage nodes (diskful) are not part of the cloudstack cluster.
DaanHoogland
DaanHoogland approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

should this go in 4.18.2/4.19 @rp- ?

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rp-
Copy link
Contributor Author

rp- commented Oct 18, 2023

should this go in 4.18.2/4.19 @rp- ?

yes, in both if my mentioned commit was also merged in 4.19.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #8114 (938f348) into 4.18 (0b3438b) will decrease coverage by 0.01%.
Report is 5 commits behind head on 4.18.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.18    #8114      +/-   ##
============================================
- Coverage     13.07%   13.07%   -0.01%     
  Complexity     9110     9110              
============================================
  Files          2720     2720              
  Lines        257526   257533       +7     
  Branches      40150    40150              
============================================
  Hits          33661    33661              
- Misses       219636   219643       +7     
  Partials       4229     4229
Files Coverage Δ
...oud/hypervisor/vmware/resource/VmwareResource.java 4.48% <0.00%> (ø)
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7423

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

[LL]Trillian test result (tid-6857)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44872 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8114-t6857-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_vm_wrong_checksum Error 37.49 test_templates.py
test_09_list_templates_download_details Failure 0.04 test_templates.py

shwstppr
shwstppr approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@shwstppr
Copy link
Contributor

@rp- is this good to merge?

@rp-
Copy link
Contributor Author

rp- commented Oct 19, 2023

@rp- is this good to merge?

yes

@shwstppr shwstppr merged commit 67cb9b9 into apache:4.18 Oct 19, 2023
@shwstppr shwstppr added this to the 4.18.2.0 milestone Oct 19, 2023
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Dec 27, 2023
@rp- @rohityadavcloud
linstor: fix template copy on non hyperconverged setups (apache#8114)
8875a94 
Making a diskful resource was meant as an optimization,
but cannot work on non hyperconverged setups,
as the storage nodes (diskful) are not part of the cloudstack cluster.

(cherry picked from commit 67cb9b9)
Signed-off-by: Rohit Yadav <[email protected]>
@rp- rp- deleted the linstor-fix-image-copy-on-non-hyperconverged branch February 5, 2024 08:38
@rp- rp- mentioned this pull request Feb 6, 2024
Closed
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request Mar 31, 2024
@rp- @rohityadavcloud
linstor: fix template copy on non hyperconverged setups (apache#8114)
5bcfb41 
Making a diskful resource was meant as an optimization,
but cannot work on non hyperconverged setups,
as the storage nodes (diskful) are not part of the cloudstack cluster.

(cherry picked from commit 67cb9b9)
Signed-off-by: Rohit Yadav <[email protected]>
rp- added a commit to LINBIT/cloudstack that referenced this pull request May 16, 2024
@rp-
linstor: fix template copy on non hyperconverged setups (apache#8114)
84ef6d7 
Making a diskful resource was meant as an optimization,
but cannot work on non hyperconverged setups,
as the storage nodes (diskful) are not part of the cloudstack cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees
No one assigned
Labels
component:primary-storage component:storage has-3rdparty-components
Projects
None yet
Milestone
4.18.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rp- @DaanHoogland @blueorangutan @shwstppr