-
Notifications
You must be signed in to change notification settings - Fork 458
[FLINK-37515] Basic support for Blue/Green deployments #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.11
Are you sure you want to change the base?
[FLINK-37515] Basic support for Blue/Green deployments #969
Conversation
...tor-api/src/main/java/org/apache/flink/kubernetes/operator/api/bluegreen/DeploymentType.java
Show resolved
Hide resolved
...main/java/org/apache/flink/kubernetes/operator/api/status/FlinkBlueGreenDeploymentState.java
Show resolved
Hide resolved
...java/org/apache/flink/kubernetes/operator/controller/FlinkBlueGreenDeploymentController.java
Outdated
Show resolved
Hide resolved
...java/org/apache/flink/kubernetes/operator/controller/FlinkBlueGreenDeploymentController.java
Outdated
Show resolved
Hide resolved
I am concerned about the number of TODOs. Things like dealing with errors and timing conditions should be in place in the initial drop of code - unless we can mark this capability as beta or the like. WDYT @gyfora ? |
@davidradl thanks for your review/comments. I've cleaned up all the outdated/invalid TODOs which pointed me 1 missing unit test, added. At this point the few remaining TODOs do not interfere with the main functionality and are not critical/open for discussion. |
… BASIC is supported).Tests to confirm the deployments are deleted accurately after the specified deletion delay.
👍 |
What is the purpose of the change
This pull request adds basic support for Blue/Green deployments as outlined by FLIP-503 (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=337677648).
Brief change log
FlinkBlueGreenDeploymentController
controller, with the capability of managing the lifecycle of these deployments.FlinkBlueGreenDeploymentController
will manage this CRD and hide from the user the details of the actual Blue/Green (Active/StandBy) jobs.FlinkDeployment
controller.Verifying this change
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors
: noDocumentation
docs/content/docs