Skip to content

[FLINK-21511][es] Bump Elasticsearch6 version to 6.8.12 #15032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zhangmeng0426
Copy link

@zhangmeng0426 zhangmeng0426 commented Feb 26, 2021

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

on Elasticsearch 6.3.1 there is a bug BulkProcessor hangs for threads deadlocked

description bug : elastic/elasticsearch#44556

fix bug : elastic/elasticsearch#47599

upgrate Elasticsearch version to 6.8.12

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache
    upgrate Elasticsearch version to 6.8.12

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: ( no )
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 26, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f5dc7ee (Fri May 28 11:06:54 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 26, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@KarmaGYZ
Copy link
Contributor

KarmaGYZ commented Mar 3, 2021

@zhangmeng0426 The commit message could be changed to "[FLINK-21511][es] Bump Elasticsearch6 version to 6.8.12". You can try to rerun the CI.

@zhangmeng0426 zhangmeng0426 changed the title [FLINK-21511][Connectors/Elasticsearch]Fix BulkProcessor hangs for threads deadlocked [FLINK-21511][es] Bump Elasticsearch6 version to 6.8.12 Mar 4, 2021
Copy link
Contributor

@KarmaGYZ KarmaGYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @zhangmeng0426 . Thanks for the contribution.
We need also to change the version in other places:

  • ElasticsearchSinkITCase
  • run-nightly-tests.sh
  • NOTICE files
  • Elasticsearch6DynamicSinkITCase

Also, the commit message should be changed.

@KarmaGYZ
Copy link
Contributor

@zhangmeng0426 Do you still work on it?

@fapaul
Copy link
Contributor

fapaul commented Jan 3, 2022

As part of https://issues.apache.org/jira/browse/FLINK-24323, we upgraded the elastic search versions. I'll close this ticket.

@fapaul fapaul closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants