matrix the build on java 17, 21 and 23 w/ ubuntu, windows and macOS using liberica #13806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jamesfredley
changed the title
matrei
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows GitHub runners are slower, but at least they run in parallel. It's ironic given that MS owns GitHub, you would think they would make them the fastest.
I don't think we want to go down these paths, but in researching the speed difference:
This PR uses Gradle Release Flag instead of Java Toolchain so the github workflow can control the version of Java.
sourceCompatibilityis deprecated and marked for removal in Gradle 9. https://docs.gradle.org/current/userguide/building_java_projects.html#sec:compiling_with_release