Skip to content

HADOOP-13614 superfluous tests #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

steveloughran
Copy link
Contributor

@steveloughran steveloughran commented Sep 30, 2016

  • where possible give all the s3a tests the superclass of {{AbstractS3ATestBase}}, clean up children.
  • ITestS3AFileSystemContract has path logic reworked so test can run in parallel
  • fixed up yarn test to work in parallel too, along with BlockingThreadPool and FastOutputStream
  • on the files changed, moved the copyright comment to being a simple comment rather than a javadoc one.

@steveloughran steveloughran force-pushed the s3/HADOOP-13614-superfluous-tests branch from 68b03be to e32266b Compare October 5, 2016 12:38
@steveloughran steveloughran force-pushed the s3/HADOOP-13614-superfluous-tests branch 2 times, most recently from 2ea9475 to 2dd7498 Compare October 20, 2016 09:10
…and move timing of upload/download times and bandwidth to contract tests
-where possible give all the s3a tests the superclass of {{AbstractS3ATestBase}}, clean up children.
-ITestS3AFileSystemContract has path logic reworked *so test can run in parallel*
-fixed up yarn test to work in parallel too, along with BlockingThreadPool and FastOutputStream
-on the files changed, moved the copyright comment to being a simple comment rather than a javadoc one.

This conflicts a bit with HADOOP-13560; this patch should go in first and then I'll address the diffs
…. Tune more tests, including ITestS3AMiniYarnCluster.

A big change here is fixing up the scale tests to work as subclasses of the S3AScaleTestBase indirect subclasses of AbstractFSContractTestBase, because that sets up the test timeout rule. Rather than have a field of the same name and hope that its timeout gets picked up, I've tuned how timeouts get set up, so the subclasses do it. All well and good, except those subclasses are being called during the initialization of the base class, that is: before the subclasses are full inited. I don't ever like doing that, though it is working here.
@steveloughran steveloughran force-pushed the s3/HADOOP-13614-superfluous-tests branch from 2dd7498 to f94d267 Compare October 24, 2016 17:11
@steveloughran steveloughran deleted the s3/HADOOP-13614-superfluous-tests branch November 1, 2016 12:10
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
This is s commit for [SAMZA-1174](https://issues.apache.org/jira/browse/SAMZA-1174). This commit involves gathering a log of operations (read, write, delete, etc.) happening on the state and publishing them into a kafka topic. It is names as "Access Log" behaving similar to changelog, but gathering log information.

Author: jmehar2 <[email protected]>
Author: Jayasi Mehar <[email protected]>
Author: s-noghabi <[email protected]>

Reviewers: Prateek Maheshwari <[email protected]>, Jagadish V <[email protected]>

Closes apache#132 from s-noghabi/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant