-
Notifications
You must be signed in to change notification settings - Fork 9k
YARN-11820. Fix UTs for TestCombinedSystemMetricsPublisher #7691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
🎊 +1 overall
This message was automatically generated. |
@GauthamBanasandra Could you help review this PR? Thank you very much! |
@ASHISH-RANJAN59 Thanks for the contribution! it makes sense to me. |
Thanks a lot for your contribution @ASHISH-RANJAN59. @slfan1989 I had a call with @ASHISH-RANJAN59 and discussed this PR. The ATS Timeline V2 uses LevelDB store for publishing the events. It works fine on Linux with LevelDB but fails on Windows since the JVM couldn't find the LevelDB DLL. While this PR fixes the unit test failure, it may not be the right fix since switching to in-memory store might suppress the issues that would be caught with LevelDB integration. So, the right fix would be to fix the unsatisfied link error on Windows. |
(!) A patch to the testing environment has been detected. |
Thanks @GauthamBanasandra, @slfan1989 for reviewing the PR. |
🎊 +1 overall
This message was automatically generated. |
Thanks for the great work @ASHISH-RANJAN59. I'll try running your change on the Jenkins CI for Windows. But it's mostly bust currently. There are only a few good nodes left, so it's difficult to get your changes running on that. Could you please do the following on your Windows computer?
|
Description of PR
UTs in the test class TestCombinedSystemMetricsPublisher is failing with below error.
java.lang.UnsatisfiedLinkError: Could not load library. Reasons: [no leveldbjni64-1.8 in java.library.path, no leveldbjni-1.8 in java.library.path, no leveldbjni in java.library.path, C:\Users\ranjanash\AppData\Local\Temp\leveldbjni-64-1-1035721066466634445.8: Can't find dependent libraries]
This PR switch to using the in-memory store for testing purposes.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?