feat: refresh table when committing to support concurrent appends #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YinZheng-Sun
changed the title
|
Thanks @YinZheng-Sun for working on this. It looks like it is a duplicate of #1772 |
Yes, this PR is inspired by #1772 and #1678. I want to accelerate the progress of this feature and have fixed the UTs |
|
I've created some subtasks on #819 that will help us implement the required validation functions that we can invoke to check that no conflicting commits have been made between two snapshots. @YinZheng-Sun would you be interested in helping out with some of those implementations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Support for Concurrent Append Operations
Refresh Table
If changes in the table's metadata are detected (indicating that other transactions have been committed during this period), update the table's metadata and the current parent_snapshot_id.
If no changes are detected, proceed with the normal commit.
Are these changes tested?
UT
Are there any user-facing changes?