Skip to content

include_field_ids flag in schema_to_pyarrow #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

sungwy
Copy link
Collaborator

@sungwy sungwy commented Jun 3, 2024

Add flag to include/exclude Parquet field IDs to pyarrow schema

Fixes: #788

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this! @syun64

@sungwy
Copy link
Collaborator Author

sungwy commented Jun 3, 2024

Thanks for the review @HonahX ! Could I ask for your help in getting this PR merged?

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow up @syun64, and thanks @HonahX for the review 🙌

@Fokko Fokko merged commit e61ef57 into apache:main Jun 3, 2024
7 checks passed
@sungwy sungwy deleted the sy-schema-to-pyarrow branch June 3, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent PyArrow Schema Field Metadata on project_table: Parquet Field ID
3 participants