Skip to content

Update docs for Maven 4 and release option #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

Bukama
Copy link
Contributor

@Bukama Bukama commented Feb 9, 2025

This PR updates several parts of the documentation to Maven 4 based on JDK 17 and aligns the docs to the new Java version schema. In particular on the front page it's mentioned that "8" is the default, where in the code it's actual "1.8" - but I wanted to keep docs consistent here.

Note: For Maven 3 branch I will create a separate PR later (maybe starting this evening)

default compiler used to compile Java sources is javax.tools.JavaCompiler.
Other compilers than <<<javac>>> can be used.
default compiler used to compile Java sources is <<<javac>>>.
If you want to use another compiler, refer to the {{{./non-javac-compilers} guide: Using Non-Javac Compilers}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use non javac compilers after: #271 @gnodet @desruisseaux ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Any compiler that implements the javax.tool.JavaCompiler interface should work. It is the case of Eclipse compiler for instance. I'm not sure if it has been tested however (not on my side), but we will fix issues or report them to ECJ if we found some.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we update non-javac-compilers guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we update non-javac-compilers guide?

And shall I do it in this PR or do you (@desruisseaux) want to do it, when "the work on sources" (see other comment) is done?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-javac-compilers guide - in next PR, the best with IT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-javac-compilers guide - in next PR, the best with IT

created https://issues.apache.org/jira/browse/MCOMPILER-609 for this.

@@ -28,21 +28,25 @@

Setting the <<<-source>>> and <<<-target>>> of the Java Compiler

(If you're are using version <<<3.13.0>>> or newer of the Compiler Plugin, use the recommended
{{{../examples/set-compiler-release.html}<<<maven.compiler.release>>> property}}.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this section may need to be updated later, after the work on <sources> element has been completed. The recommended approach would then be to specify the release together with the declaration of the sources.

No change needed now, it is just a reminder for revisiting later.

@Bukama Bukama merged commit f79c7fd into apache:master Feb 16, 2025
26 checks passed
@Bukama Bukama deleted the releasedoscsmaven4 branch February 16, 2025 06:08
@github-actions github-actions bot added this to the 4.0.0-beta-2 milestone Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants