[SUREFIRE-2298] fix xml output with junit 5 nested classes #828
Conversation
Signed-off-by: Olivier Lamy <[email protected]>
| * <testcase name="outerTest" classname="SecondNestedTest" time="0.001"/> | ||
| * <testcase name="innerTest" classname="BaseNestedTest$Inner" time="0.0"/> | ||
| * </testsuite> | ||
| */ |
Signed-off-by: Olivier Lamy <[email protected]>
| Optional<UniqueId.Segment> classSegment = testIdentifier.getUniqueIdObject().getSegments().stream() | ||
| .filter(segment -> "class".equals(segment.getType())) | ||
| .findFirst(); |
There was a problem hiding this comment.
You shouldn't parse the UniqueId because it's considered to be an implementation detail. Instead, you should use testPlan.getParent(testIdentifier) to find the right level. If this should only support class-based engines, finding the last one with a TestSource of type ClassSource should work. If this should also work for file-based engines like Cucumber, you might want to use a differeny heuristic instead. Maybe always use the level immediate below the root (engine descriptor)? If it has a ClassSource, use that; otherwise, use the display name (similar to what toClassMethodName does)?
There was a problem hiding this comment.
Yeah, Cucumber was also broken by the last patch, so the alternative heuristic should be used.
Signed-off-by: Olivier Lamy [email protected]
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.