Avoid getLastMessageId RPC when calling hasMessageAvailable after seek by timestamp #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
force-pushed
the
bewaremypower/fix-has-message-available-regression
branch
from
89432d2 to
8c3bc71
Compare
BewareMyPower
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#422 introduces a regression that
hasSoughtByTimestamp_is never set back to false after the seek operation is done. Then,getLastMessageIdAsyncwill always be called even iflastDequedMessageId_is not earliest, which means no messages have been received.Modifications
incomingMessages_is not empty in case messages are never received by the caller but they are already cached.testHasMessageAvailableAfterSeekTimestampto cover the change