Skip to content

Enable required check status for pr validation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ github:
rebase: false
protected_branches:
main:
# required_status_checks:
required_status_checks:
# # strict means "Require branches to be up to date before merging".
# strict: false
strict: false
# # Contexts are the names of checks that must pass.
# # See ./github/workflows/README.md for more documentation on this list.
# contexts:
# - Pulsar CI checks completed
contexts:
- Check Completion

required_pull_request_reviews:
dismiss_stale_reviews: false
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/ci-pr-validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,12 @@ jobs:

- name: Build and test Mac wheels
run: pkg/mac/build-mac-wheels.sh ${{matrix.py.version}}

# Job that will be required to complete and depends on all the other jobs
check-completion:
name: Check Completion
runs-on: ubuntu-latest
needs: [unit-tests, linux-wheel, mac-wheels]

steps:
- run: true