Enhance developer experience for debugging tests and add related README #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation When I ran `python3 ./tests/pulsar_tests.py`, I found some tests failed. However, when I went into the container that was started by `./build-support/pulsar-test-service-start.sh`, the logs are incomplete because the immediate flush is disabled by default. Finally I found the error is caused by the relative path in tests. The certs are under `tests/test-conf` directory, but `pulsar_tests.py` uses the `test-conf/` relative path. Since `tests/run-unit-tests.sh` first goes to the `tests` directory before running the tests, CI works well. But a developer might just want to run a specific test from any possible directory, e.g. ```bash python3 ./tests/pulsar_tests.py PulsarTest.test_tls_auth ``` Then it could fail and he cannot see complete logs. ### Modifications - Modify `immediateFlush` to true - Use absolute path to represent `test-conf/` in `pulsar_tests.py` - Add an initial README for quick start
BewareMyPower
requested review from
merlimat,
nodece,
RobertIndie,
Demogorgon314,
Anonymitaet and
momo-jun
merlimat
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I ran
python3 ./tests/pulsar_tests.py, I found some tests failed. However, when I went into the container that was started by./build-support/pulsar-test-service-start.sh, the logs are incomplete because the immediate flush is disabled by default.Finally I found the error is caused by the relative path in tests. The certs are under
tests/test-confdirectory, butpulsar_tests.pyuses thetest-conf/relative path. Sincetests/run-unit-tests.shfirst goes to thetestsdirectory before running the tests, CI works well. But a developer might just want to run a specific test from any possible directory, e.g.Then it could fail and he cannot see complete logs.
Modifications
immediateFlushto truetest-conf/inpulsar_tests.py