Skip to content

Fixed building of Linux wheel files #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2022

Conversation

merlimat
Copy link
Contributor

The current build process for Python wheels is to fetch the RPM packages of the C++ release and use the libpulsar.so from there.

There are some issues due to incompatibilities between different versions of libstdc++, causing segmentation faults. In particular problems with callbacks and std::function objects compiled in different environments.

To avoid these issues, we need to compile the C++ client lib when we're building the Python wrapper.

@merlimat merlimat added the build label Nov 12, 2022
@merlimat merlimat added this to the 3.0.0 milestone Nov 12, 2022
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Verified the Python 3.8 wheel on Ubuntu 20.04 (installed from apt) and CentOS 7 (built from source code).

@BewareMyPower BewareMyPower merged commit 1554e39 into apache:main Nov 12, 2022
@merlimat merlimat deleted the fix-python-wheels branch November 17, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants