Migrate from Boost.Python to PyBind11 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#24 ### Motivation Remove the Boost.Python dependency so that on Windows there will be no DLL dependencies because PyBind11 is header only. ### Modifications Since PyBind11 can perform type conversions between C++ types (STL, function, etc.) and Python types (list, dict, lambda, etc.), some wrapper classes are replaced with the classes in the Pulsar C++ library. The only API changes are related to the `_pulsar` module, which should not be used directly. The authentication related classes were wrapper classes with constructors before, now they are created by the static `create` methods from Pulsar C++ API. Fix the CMakeLists.txt and the workflows to build Python wheels on Linux, macOS and Windows. Finally add a workflow to build Windows wheels during a release.
Demogorgon314
approved these changes
Nov 28, 2022
|
This seems to have been a good solution, the previous version would break if you had any code that used opentelemetry-instrument's automatic instrumentation and with a build from master using pybind11 fixes this kind of issue. |
|
Any chance we get an alpha version of this in pypi? Or is it better to upload to private repositories? |
|
@jaysonsantos The official release will start soon. Just waiting for the latest C++ client release because it has Windows artifacts now. You can try these wheels built in my local repo with the same commit id with the current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Motivation
Remove the Boost.Python dependency so that on Windows there will be no DLL dependencies because PyBind11 is header only.
Modifications
Since PyBind11 can perform type conversions between C++ types (STL, function, etc.) and Python types (list, dict, lambda, etc.), some wrapper classes are replaced with the classes in the Pulsar C++ library.
The only API changes are related to the
_pulsarmodule, which should not be used directly. The authentication related classes were wrapper classes with constructors before, now they are created by the staticcreatemethods from Pulsar C++ API.Fix the CMakeLists.txt and the workflows to build Python wheels on Linux, macOS and Windows. Finally add a workflow to build Windows wheels during a release.