style: deal with B024 added to flake8 recently #232
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -35,7 +35,7 @@ | |||
| from skywalking.trace.context import Segment | |||
|
|
|||
| __started = False | |||
| __protocol = Protocol() # type: Protocol | |||
| __protocol = None # type: Protocol | |||
There was a problem hiding this comment.
Incompatible variable type: __protocol is declared to have type Protocol but is used as type None.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
skywalking/trace/span.py
Outdated
| ): | ||
| if cls is Span: | ||
| raise TypeError(f"only children of '{cls.__name__}' may be instantiated") | ||
| return super.__new__(cls, *args, **kwargs) |
More details about B024 here PyCQA/flake8-bugbear#274 * ./skywalking/agent/protocol/__init__.py:22:1: B024 Protocol is an abstract base class, but it has no abstract methods. Set 'heartbeat', 'report' and 'report_log' as abstract method * ./skywalking/trace/span.py:36:1: B024 Span is an abstract base class, but it has no abstract methods. Prevent base class Span from being directly instantiated by raising error in __new__ with reference to https://stackoverflow.com/questions/7989042/preventing-a-class-from-direct-instantiation-in-python * ./tests/plugin/base.py:35:1: B024 TestPluginBase is an abstract base class Due to pytest instantiating parent class, TestPluginBase has to be instantiable.
|
So far, the only problem is that the test of flask uses skywalking-python/skywalking/trace/context.py Line 122 in 5aca0df Span has to be instantiable too.
Seems to be no alternatives for |
Yeah just keep it for now. :) |
|
LGTM |
More details about B024 here PyCQA/flake8-bugbear#274
./skywalking/agent/protocol/init.py:22:1: B024 Protocol is an abstract base class, but it has no abstract methods.
Set 'heartbeat', 'report' and 'report_log' as abstract method
./skywalking/trace/span.py:36:1: B024 Span is an abstract base class, but it has no abstract methods.
Prevent base class Span from being directly instantiated by raising error in__new__with reference tohttps://stackoverflow.com/questions/7989042/preventing-a-class-from-direct-instantiation-in-python
./tests/plugin/base.py:35:1: B024 TestPluginBase is an abstract base class
Due to pytest instantiating parent class
for searching test functions, TestPluginBase has to be instantiable.