[SPARK-51193][CORE] Upgrade Netty to 4.1.118.Final and netty-tcnative to 2.0.70.Final #49923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-51193
branch
from
06ba0e7 to
9d59293
Compare
dongjoon-hyun
changed the title
|
Could you review this PR, @LuciferYang ? Technically, there are two CVE patches here. |
|
Thank you always, @LuciferYang ! |
yaooqinn
approved these changes
Feb 13, 2025
|
Thank you, @yaooqinn ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 13, 2025
… to 2.0.70.Final ### What changes were proposed in this pull request? This PR aims to upgrade the following for Apache Spark 4.0.0. - netty to 4.1.118.Final - netty-tcnative to 2.0.70.Final ### Why are the changes needed? To bring the latest bug fixes - https://netty.io/news/2025/02/10/4-1-118-Final.html - https://github.com/netty/netty/releases/tag/netty-4.1.118.Final - netty/netty#14790 - SslHandler doesn't correctly validate packets which can lead to native crash when using native SSLEngine - Denial of Service attack on windows app using Netty, again ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49923 from dongjoon-hyun/SPARK-51193. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 0a10232) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Merged to master/4.0. |
FMX
pushed a commit
to apache/celeborn
that referenced
this pull request
Feb 15, 2025
### What changes were proposed in this pull request? Bump Netty version from 4.1.115.Final to 4.1.118.Final. ### Why are the changes needed? The Netty 4.1.118.Final version has been released, which netty version is 4.1.115.Final at present. The changes between 4.1.115.Final and 4.1.118.Final is as follows: - 4.1.116.Final: https://netty.io/news/2024/12/17/4-1-116-Final.html - 4.1.117.Final: https://netty.io/news/2025/01/14/4-1-117-Final.html - 4.1.118.Final: https://netty.io/news/2025/02/10/4-1-118-Final.html - **SslHandler doesn't correctly validate packets which can lead to native crash when using native SSLEngine.** - **Denial of Service attack on windows app using Netty, again.** Backport: - apache/spark#49756 - apache/spark#49923 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #3098 from SteNicholas/CELEBORN-1864. Authored-by: Nicholas Jiang <[email protected]> Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade the following for Apache Spark 4.0.0.
Why are the changes needed?
To bring the latest bug fixes
Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.