Skip to content

Bug/not display trimmed x label #4964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

youngPerson1999
Copy link
Contributor

New Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4745

  • In XAxes.js, the checkForOverflowingLabels function in AxesUtil.js checks whether an overflow occurs in the previous label, exceeding the allocated width of the current x-axis label.
  • If an overflow is detected, the current label is not rendered.
  • In apexcharts.js, the xAxisLabelCorrections function in Graphics.js replaces the overflowing portion with "..." if trim == true.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@youngPerson1999
Copy link
Contributor Author

@junedchhipa
I'm really sorry, but I have a question. Please tell me if there are other fix about my code. I don't know what to do bcs you never comment aboout this pull request. thank you

@junedchhipa
Copy link
Contributor

@youngPerson1999 Sorry for the delayed response.
Looks good to me. Thanks for the contribution.

@junedchhipa junedchhipa merged commit f34da74 into apexcharts:main May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with long xaxis label trimming
4 participants