Fixes ignoring type checks during denormalization #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IckleChris
commented
May 19, 2018
| @@ -201,7 +201,10 @@ protected function setAttributeValue($object, $attribute, $value, $format = null | |||
| return; | |||
| } | |||
|
|
|||
| $this->validateType($attribute, $type, $value, $format); | |||
| if (empty($context[AbstractObjectNormalizer::DISABLE_TYPE_ENFORCEMENT])) { | |||
There was a problem hiding this comment.
Looks like the usage of the constant from the Serializer is causing failing tests, should the constant be defined anew within this class (despite the duplication)?
…DISABLE_TYPE_ENFORCEMENT flag during denormalization
alanpoulain
reviewed
Feb 26, 2019
alanpoulain
approved these changes
Feb 26, 2019
|
Thanks @IckleChris ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the denormalization process to honour the ObjectNormalizer::DISABLE_TYPE_ENFORCEMENT flag, allowing invalid types to be handled by the validation layer instead of endpoints returning (by default) 500 status serialization errors.