Skip to content

fix(metadata): wrong service loaded w/ backward compatibility #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2022
Merged

fix(metadata): wrong service loaded w/ backward compatibility #4716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Symfony/Bundle/Resources/config/doctrine_mongodb_odm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,6 @@
<tag name="api_platform.doctrine_mongodb.odm.aggregation_extension.collection" priority="16" />
</service>
<service id="ApiPlatform\Doctrine\Odm\Extension\OrderExtension" alias="api_platform.doctrine_mongodb.odm.aggregation_extension.order" />

<service id="api_platform.doctrine_mongodb.odm.metadata.property.identifier_metadata_factory"
class="ApiPlatform\Doctrine\Odm\Metadata\Property\DoctrineMongoDbOdmPropertyMetadataFactory"
decorates="api_platform.metadata.property.identifier_metadata_factory"
decoration-priority="40">
<argument type="service" id="doctrine_mongodb"/>
<argument type="service" id="api_platform.doctrine_mongodb.odm.metadata.property.identifier_metadata_factory.inner"/>
</service>
</services>

</container>
8 changes: 8 additions & 0 deletions src/Symfony/Bundle/Resources/config/v3/doctrine_odm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,13 @@
<argument type="service" id="doctrine_mongodb" />
<argument type="service" id="api_platform.doctrine.odm.metadata.resource.metadata_collection_factory.inner" />
</service>

<service id="api_platform.doctrine_mongodb.odm.metadata.property.identifier_metadata_factory"
class="ApiPlatform\Doctrine\Odm\Metadata\Property\DoctrineMongoDbOdmPropertyMetadataFactory"
decorates="api_platform.metadata.property.identifier_metadata_factory"
decoration-priority="40">
<argument type="service" id="doctrine_mongodb"/>
<argument type="service" id="api_platform.doctrine_mongodb.odm.metadata.property.identifier_metadata_factory.inner"/>
</service>
</services>
</container>
7 changes: 7 additions & 0 deletions tests/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,11 @@ private function assertContainerHas(array $services, array $aliases = [])
}
}

private function assertNotContainerHasService(string $service)
{
$this->assertFalse($this->container->hasDefinition($service), sprintf('Service "%s" found.', $service));
}

private function assertContainerHasAlias(string $alias)
{
$this->assertTrue($this->container->hasAlias($alias), sprintf('Alias "%s" not found.', $alias));
Expand Down Expand Up @@ -1752,6 +1757,8 @@ public function testLegacyServicesMetadataBackwardCompatibilityLayer(): void
$this->assertServiceHasTags('api_platform.identifier.date_normalizer', ['api_platform.identifier.denormalizer']);
$this->assertServiceHasTags('api_platform.listener.view.write.legacy', ['kernel.event_listener']);
$this->assertServiceHasTags('api_platform.listener.request.read.legacy', ['kernel.event_listener']);

$this->assertNotContainerHasService('api_platform.doctrine_mongodb.odm.metadata.property.identifier_metadata_factory');
}

public function testRectorConfiguration(): void
Expand Down