Skip to content

Fix Graphql issues #4928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

webda2l
Copy link
Contributor

@webda2l webda2l commented Sep 8, 2022

Q A
Branch? main
Tickets #4613 (comment) & #4613 (comment)
License MIT

This restore the previous behavior of the 2.6

@webda2l webda2l changed the title Fix Graphql collection field with disabled pagination has a wrong type detection Fix Graphql issues Sep 8, 2022
@alanpoulain
Copy link
Member

Hello,
Thanks for working on this!
Since it's two different issues, could you make two PR?
Also it would be great to have Behat tests to make sure it doesn't break later 🙂

@soyuka
Copy link
Member

soyuka commented Sep 8, 2022

Nice patch, can you target the 2.7 branch ? Commit messages should follow https://www.conventionalcommits.org/ for example:

fix(graphql): link relations requires the property

@webda2l
Copy link
Contributor Author

webda2l commented Sep 8, 2022

There are still issues with my use case before going further but sure, I will consider yours feedbacks :)

@webda2l webda2l closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants