Skip to content

fix(graphql): always allow to query nested resources #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix(graphql): always allow to query nested resources #5112

merged 2 commits into from
Nov 4, 2022

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Nov 3, 2022

Rework of #5102

alanpoulain
alanpoulain reviewed Nov 3, 2022
View reviewed changes
src/Symfony/Bundle/Resources/config/graphql.xml Outdated
@@ -134,6 +133,7 @@
<argument type="service" id="api_platform.pagination" />
<argument type="service" id="api_platform.name_converter" on-invalid="ignore" />
<argument>%api_platform.graphql.nesting_separator%</argument>
<argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore"></argument>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore"></argument>
<argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore" />

@soyuka soyuka force-pushed the fix/graphql-nested-resource-operation branch 3 times, most recently from 432ff12 to e38414d Compare November 4, 2022 15:28
alanpoulain
alanpoulain reviewed Nov 4, 2022
View reviewed changes
src/Symfony/Bundle/Resources/config/graphql.xml Outdated
@@ -133,6 +133,7 @@
<argument type="service" id="api_platform.pagination" />
<argument type="service" id="api_platform.name_converter" on-invalid="ignore" />
<argument>%api_platform.graphql.nesting_separator%</argument>
<argument type="service" id="api_platform.graphql_metadata.resource.metadata_collection_factory" on-invalid="ignore" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the on-invalid is necessary.

@soyuka soyuka force-pushed the fix/graphql-nested-resource-operation branch from e38414d to 2a75c00 Compare November 4, 2022 15:49
@soyuka soyuka merged commit bbeaf70 into api-platform:3.0 Nov 4, 2022
@soyuka soyuka deleted the fix/graphql-nested-resource-operation branch November 4, 2022 15:58
@alanpoulain alanpoulain mentioned this pull request Nov 4, 2022
Closed
1 task
soyuka added a commit that referenced this pull request Nov 4, 2022
@soyuka @ArnoudThibaut
@davy-beauzil @Korbeil @norival @alanpoulain @liviucmg @WilliamPeralta
Merge 3.0 into main (#5121)
6abd0fe 
* fix: update yaml extractor test file coding standard (#5068)

* fix(graphql): add clearer error message when TwigBundle is disabled but graphQL clients are enabled (#5064)

* fix(metadata): add class key in payload argument resolver (#5067)

* fix: add class key in payload argument resolver

* add null if everything else goes wrong

* fix: upgrade command remove ApiSubresource attribute  (#5049)

Fixes #5038

* fix(doctrine): use abitrary index instead of value (#5079)

* fix: uri template should respect rfc 6570 (#5080)

* fix: remove @internal annotation for Operations (#5089)

See #5084

* fix(metadata): define a name on a single operation (#5090)

fixes #5082

* fix(metadata): deprecate when user decorates in legacy mode (#5091)

fixes #5078

* fix(graphql): use right nested operation (#5102)

* Revert "fix(graphql): use right nested operation (#5102)" (#5111)

This reverts commit 44337dd.

* fix(graphql): always allow to query nested resources (#5112)

* fix(graphql): always allow to query nested resources

* review

Co-authored-by: Alan Poulain <[email protected]>

* chore: php-cs-fixer update

* fix: only alias if exists for opcache preload

Fixes api-platform/api-platform#2284 (#5110)

Co-authored-by: Liviu Mirea <[email protected]>

* chore: php-cs-fixer update (#5118)

* chore: php-cs-fixer update

* chore: php-cs-fixer update

* fix(metadata): upgrade script keep operation name (#5109)

origin: #5105

Co-authored-by: WilliamPeralta <[email protected]>

* chore: v2.7.3 changelog

* chore: v3.0.3 changelog

Co-authored-by: helyakin <[email protected]>
Co-authored-by: ArnoudThibaut <[email protected]>
Co-authored-by: davy-beauzil <[email protected]>
Co-authored-by: Baptiste Leduc <[email protected]>
Co-authored-by: Xavier Laviron <[email protected]>
Co-authored-by: Alan Poulain <[email protected]>
Co-authored-by: Liviu Cristian Mirea-Ghiban <[email protected]>
Co-authored-by: Liviu Mirea <[email protected]>
Co-authored-by: WilliamPeralta <[email protected]>
alanpoulain
alanpoulain reviewed Nov 6, 2022
View reviewed changes
src/GraphQl/Metadata/Factory/GraphQlNestedOperationResourceMetadataFactory.php
Comment on lines +54 to +61
if (class_exists($resourceClass)) {
$refl = new \ReflectionClass($resourceClass);
$attribute = $refl->getAttributes(ApiResource::class)[0] ?? null;
$attributeInstance = $attribute?->newInstance();
if ($filters = $attributeInstance?->getFilters()) {
$apiResource = $apiResource->withFilters($filters);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This should work with XML/YAML too.

@alanpoulain alanpoulain mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soyuka @alanpoulain