feat: support collect denormalization errors #5170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Nov 7, 2022
features/main/validation.feature
Outdated
| ] | ||
| } | ||
| """ | ||
| And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8" |
There was a problem hiding this comment.
nitpick: Maybe this line should be before.
There was a problem hiding this comment.
I think we check the response so its ok
alanpoulain
reviewed
Nov 7, 2022
| @@ -419,7 +419,7 @@ protected function setAttributeValue(object $object, string $attribute, mixed $v | |||
| * | |||
| * @throws InvalidArgumentException | |||
| */ | |||
| protected function validateType(string $attribute, Type $type, mixed $value, string $format = null): void | |||
| protected function validateType(string $attribute, Type $type, mixed $value, string $format = null, array &$context): void | |||
There was a problem hiding this comment.
issue: It's a BC break (add a default value?)
There was a problem hiding this comment.
it doesn't have to be a reference also
alanpoulain
reviewed
Nov 7, 2022
| @@ -226,7 +226,6 @@ private function normalizeDefaults(array $defaults): array | |||
| foreach ($rc->getConstructor()->getParameters() as $param) { | |||
| $publicProperties[$param->getName()] = true; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
nitpick: Please revert these changes.
alanpoulain
reviewed
Nov 7, 2022
Comment on lines
20
to
22
| /** | ||
| * DummyWithCollectDenormalizationErrors. | ||
| */ |
norkunas
reviewed
Nov 25, 2022
| if (!$exception instanceof NotNormalizableValueException) { | ||
| continue; | ||
| } | ||
| $message = sprintf('The type of the "%s" attribute must be "%s", "%s" given.', $exception->getPath(), implode(', ', $exception->getExpectedTypes() ?? []), $exception->getCurrentType()); |
There was a problem hiding this comment.
Maybe it would be better to use by default a message like in Symfony Validator componen: This value should be of type {{ type }}. so it would be translated if validator and translation components are dependencies of application?
alanpoulain
force-pushed
the
issue-4793
branch
4 times, most recently
from
de28527 to
aaf4452
Compare
alanpoulain
force-pushed
the
issue-4793
branch
from
aaf4452 to
0864591
Compare
alanpoulain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#21239 and symfony/symfony#42502.
Add property
collectDenormalizationErrorsin Operation (set tofalseby default), setting this property totruewill enable collecting denormalization type errors to return them as constraint violations.