fix(metadata): _format broken bc promise on #5080 #5187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Nov 15, 2022
|
|
||
| if ($legacyFormat && ($this->triggerLegacyFormatOnce[$operation->getClass()] ?? true)) { | ||
| $this->triggerLegacyFormatOnce[$operation->getClass()] = false; | ||
| trigger_deprecation('api-platform/core', '3.0', sprintf('The special Symfony parameter ".{_format}" in your URI Template is deprecated, use an RFC6570 variable "{.format}" on the class "%s" instead. We will only use the RFC6570 compatible variable in 4.0.', $operation->getClass())); |
There was a problem hiding this comment.
Are we using trigger_deprecation now? We need to make sure it's not a dev dep then.
There was a problem hiding this comment.
its a dependency of http-foundation
There was a problem hiding this comment.
Sure but it should be a direct dependency now.
alanpoulain
reviewed
Nov 15, 2022
|
|
||
| if ($legacyFormat && ($this->triggerLegacyFormatOnce[$operation->getClass()] ?? true)) { | ||
| $this->triggerLegacyFormatOnce[$operation->getClass()] = false; | ||
| trigger_deprecation('api-platform/core', '3.0', sprintf('The special Symfony parameter ".{_format}" in your URI Template is deprecated, use an RFC6570 variable "{.format}" on the class "%s" instead. We will only use the RFC6570 compatible variable in 4.0.', $operation->getClass())); |
There was a problem hiding this comment.
Suggested change
| trigger_deprecation('api-platform/core', '3.0', sprintf('The special Symfony parameter ".{_format}" in your URI Template is deprecated, use an RFC6570 variable "{.format}" on the class "%s" instead. We will only use the RFC6570 compatible variable in 4.0.', $operation->getClass())); | |
| trigger_deprecation('api-platform/core', '3.0', sprintf('The special Symfony parameter ".{_format}" in your URI Template is deprecated, use an RFC6570 variable "{._format}" on the class "%s" instead. We will only use the RFC6570 compatible variable in 4.0.', $operation->getClass())); |
soyuka
force-pushed
the
fix/format-breaking-change
branch
from
906cd74 to
cc074be
Compare
soyuka
force-pushed
the
fix/format-breaking-change
branch
from
cc074be to
f880edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5080 for details